Re: [PATCH] drm/bridge: sil_sii8620: initialize return of sii8620_readb

2020-07-13 Thread Sam Ravnborg
Hi Tom. On Sun, Jul 12, 2020 at 08:24:53AM -0700, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis flags this error > > sil-sii8620.c:184:2: warning: Undefined or garbage value > returned to caller [core.uninitialized.UndefReturn] > return ret; > ^~ >

Re: [PATCH] drm/bridge: sil_sii8620: initialize return of sii8620_readb

2020-07-13 Thread Andrzej Hajda
On 12.07.2020 17:24, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis flags this error > > sil-sii8620.c:184:2: warning: Undefined or garbage value >returned to caller [core.uninitialized.UndefReturn] > return ret; > ^~ > > sii8620_readb calls

Re: [PATCH] drm/bridge: sil_sii8620: initialize return of sii8620_readb

2020-07-12 Thread Laurent Pinchart
Hi Tom, Thank you for the patch. On Sun, Jul 12, 2020 at 08:24:53AM -0700, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis flags this error > > sil-sii8620.c:184:2: warning: Undefined or garbage value > returned to caller [core.uninitialized.UndefReturn] > return

[PATCH] drm/bridge: sil_sii8620: initialize return of sii8620_readb

2020-07-12 Thread trix
From: Tom Rix clang static analysis flags this error sil-sii8620.c:184:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] return ret; ^~ sii8620_readb calls sii8620_read_buf. sii8620_read_buf can return without setting its