Re: [PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate

2022-03-14 Thread Robin Murphy
On 2022-03-14 11:31, Robin Murphy wrote: On 2022-03-13 12:56, Peter Geis wrote: On Sun, Mar 13, 2022 at 6:13 AM Piotr Oniszczuk wrote: Wiadomość napisana przez Peter Geis w dniu 26.01.2022, o godz. 21:24: The hdmi-cec clock must be 32khz in order for cec to work correctly. Ensure after

Re: [PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate

2022-03-14 Thread Robin Murphy
On 2022-03-13 12:56, Peter Geis wrote: On Sun, Mar 13, 2022 at 6:13 AM Piotr Oniszczuk wrote: Wiadomość napisana przez Peter Geis w dniu 26.01.2022, o godz. 21:24: The hdmi-cec clock must be 32khz in order for cec to work correctly. Ensure after enabling the clock we set it in order for

Re: [PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate

2022-03-14 Thread Piotr Oniszczuk
> Wiadomość napisana przez Peter Geis w dniu 13.03.2022, > o godz. 13:56: > >> > > I was worried about that, thanks for testing it. > Can you send me the cec_clk rate before and after this patch? > Here it is: working: enable prepare protect

Re: [PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate

2022-03-14 Thread Piotr Oniszczuk
> Wiadomość napisana przez Peter Geis w dniu 26.01.2022, > o godz. 21:24: > > The hdmi-cec clock must be 32khz in order for cec to work correctly. > Ensure after enabling the clock we set it in order for the hardware to > work as expected. > Warn on failure, in case this is a static clock

Re: [PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate

2022-03-13 Thread Peter Geis
On Sun, Mar 13, 2022 at 6:13 AM Piotr Oniszczuk wrote: > > > > > Wiadomość napisana przez Peter Geis w dniu > > 26.01.2022, o godz. 21:24: > > > > The hdmi-cec clock must be 32khz in order for cec to work correctly. > > Ensure after enabling the clock we set it in order for the hardware to > >

Re: [PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate

2022-01-28 Thread Peter Geis
On Thu, Jan 27, 2022 at 4:33 AM Sascha Hauer wrote: > > Hi Peter, > > On Wed, Jan 26, 2022 at 03:24:26PM -0500, Peter Geis wrote: > > The hdmi-cec clock must be 32khz in order for cec to work correctly. > > Ensure after enabling the clock we set it in order for the hardware to > > work as

Re: [PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate

2022-01-27 Thread Sascha Hauer
Hi Peter, On Wed, Jan 26, 2022 at 03:24:26PM -0500, Peter Geis wrote: > The hdmi-cec clock must be 32khz in order for cec to work correctly. > Ensure after enabling the clock we set it in order for the hardware to > work as expected. > Warn on failure, in case this is a static clock that is

Re: [PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate

2022-01-26 Thread Fabio Estevam
On Wed, Jan 26, 2022 at 5:25 PM Peter Geis wrote: > + > + ret = clk_set_rate(hdmi->cec_clk, HDMI_CEC_CLK_RATE); > + if (ret) > + dev_warn(hdmi->dev, "Cannot set HDMI cec clock rate: > %d\n", ret); You are setting the cec clock rate after it has

[PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate

2022-01-26 Thread Peter Geis
The hdmi-cec clock must be 32khz in order for cec to work correctly. Ensure after enabling the clock we set it in order for the hardware to work as expected. Warn on failure, in case this is a static clock that is slighty off. Fixes hdmi-cec support on Rockchip devices. Fixes: ebe32c3e282a