Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix ti_sn_bridge_set_dsi_rate function

2024-04-10 Thread Doug Anderson
Hi, On Wed, Apr 10, 2024 at 4:42 AM Jayesh Choudhary wrote: > > Hello Doug, > > Thanks for the review. > > On 08/04/24 14:33, Doug Anderson wrote: > > Hi, > > > > On Mon, Apr 8, 2024 at 12:36 AM Jayesh Choudhary wrote: > >> > >> Due to integer calculations, the rounding off can cause errors in

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix ti_sn_bridge_set_dsi_rate function

2024-04-10 Thread Jayesh Choudhary
Hello Doug, Thanks for the review. On 08/04/24 14:33, Doug Anderson wrote: Hi, On Mon, Apr 8, 2024 at 12:36 AM Jayesh Choudhary wrote: Due to integer calculations, the rounding off can cause errors in the final value propagated in the registers. Considering the example of 1080p (very

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix ti_sn_bridge_set_dsi_rate function

2024-04-08 Thread Doug Anderson
Hi, On Mon, Apr 8, 2024 at 12:36 AM Jayesh Choudhary wrote: > > Due to integer calculations, the rounding off can cause errors in the final > value propagated in the registers. > Considering the example of 1080p (very common resolution), the mode->clock > is 148500, dsi->lanes = 4, and bpp = 24,

[PATCH] drm/bridge: ti-sn65dsi86: Fix ti_sn_bridge_set_dsi_rate function

2024-04-08 Thread Jayesh Choudhary
Due to integer calculations, the rounding off can cause errors in the final value propagated in the registers. Considering the example of 1080p (very common resolution), the mode->clock is 148500, dsi->lanes = 4, and bpp = 24, with the previous logic, the DSI clock frequency would come as 444 when