[PATCH] drm/crtc: fix connector reference counting mismatch in drm_crtc_helper_set_config

2016-06-03 Thread Daniel Vetter
On Fri, Jun 03, 2016 at 10:27:11AM +0200, Philipp Zabel wrote: > Am Donnerstag, den 02.06.2016, 22:25 +0200 schrieb Daniel Vetter: > [...] > > > [drm:drm_ioctl] pid=205, dev=0xe201, auth=1, DRM_IOCTL_MODE_SETCRTC > > > [drm:drm_mode_setcrtc] [CRTC:24:crtc-0] > > >

[PATCH] drm/crtc: fix connector reference counting mismatch in drm_crtc_helper_set_config

2016-06-03 Thread Thierry Reding
On Thu, Jun 02, 2016 at 10:25:46PM +0200, Daniel Vetter wrote: > On Thu, Jun 02, 2016 at 07:28:30PM +0200, Philipp Zabel wrote: > > Am Donnerstag, den 02.06.2016, 18:21 +0200 schrieb Daniel Vetter: [...] > > > Which means when we drop that 1 reference in the saved connector (which is > > >

[PATCH] drm/crtc: fix connector reference counting mismatch in drm_crtc_helper_set_config

2016-06-03 Thread Philipp Zabel
Am Donnerstag, den 02.06.2016, 22:25 +0200 schrieb Daniel Vetter: [...] > > [drm:drm_ioctl] pid=205, dev=0xe201, auth=1, DRM_IOCTL_MODE_SETCRTC > > [drm:drm_mode_setcrtc] [CRTC:24:crtc-0] > > [drm:drm_mode_setcrtc] [CONNECTOR:36:LVDS-1] ^ This is printed after each

[PATCH] drm/crtc: fix connector reference counting mismatch in drm_crtc_helper_set_config

2016-06-02 Thread Daniel Vetter
On Thu, Jun 02, 2016 at 07:28:30PM +0200, Philipp Zabel wrote: > Hi Daniel, > > Am Donnerstag, den 02.06.2016, 18:21 +0200 schrieb Daniel Vetter: > [...] > > > Only the reference count of connectors that weren't previously bound to > > > an encoder should be incremented after a call to > > >

[PATCH] drm/crtc: fix connector reference counting mismatch in drm_crtc_helper_set_config

2016-06-02 Thread Philipp Zabel
Hi Daniel, Am Donnerstag, den 02.06.2016, 18:21 +0200 schrieb Daniel Vetter: [...] > > Only the reference count of connectors that weren't previously bound to > > an encoder should be incremented after a call to drm_crtc_helper_set_config. > > And only the reference count of connectors that were

[PATCH] drm/crtc: fix connector reference counting mismatch in drm_crtc_helper_set_config

2016-06-02 Thread Daniel Vetter
On Thu, Jun 02, 2016 at 06:02:12PM +0200, Philipp Zabel wrote: > Since commit 0955c1250e96 ("drm/crtc: take references to connectors used > in a modeset. (v2)"), the reference counts of all connectors in the > drm_mode_set given to drm_crtc_helper_set_config are incremented, and then > the

[PATCH] drm/crtc: fix connector reference counting mismatch in drm_crtc_helper_set_config

2016-06-02 Thread Philipp Zabel
Since commit 0955c1250e96 ("drm/crtc: take references to connectors used in a modeset. (v2)"), the reference counts of all connectors in the drm_mode_set given to drm_crtc_helper_set_config are incremented, and then the reference counts of all connectors are decremented on success, but in a