[PATCH] drm/etnaviv: introduce a function to create etnaviv platform device

[Sui Jingfeng]

 This patch make the code more clear, call of_node_put(np) only once
 in for_each_compatible_node(np, NULL, "vivante,gc") loop instead of
 three.

Signed-off-by: Sui Jingfeng <15330273...@189.cn>
---
 drivers/gpu/drm/etnaviv/etnaviv_drv.c | 36 +++++++++++++++++----------
 1 file changed, 23 insertions(+), 13 deletions(-)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c 
b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index 0b756ecb1bc2..42cb624cf1ae 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -659,6 +659,26 @@ static struct platform_driver etnaviv_platform_driver = {
 
 static struct platform_device *etnaviv_drm;
 
+static int etnaviv_create_platform_device(const char *name)
+{
+       struct platform_device *pdev;
+       int ret;
+
+       pdev = platform_device_alloc(name, PLATFORM_DEVID_NONE);
+       if (!pdev)
+               return -ENOMEM;
+
+       ret = platform_device_add(pdev);
+       if (ret) {
+               platform_device_put(pdev);
+               return ret;
+       }
+
+       etnaviv_drm = pdev;
+
+       return 0;
+}
+
 static int __init etnaviv_init(void)
 {
        struct platform_device *pdev;
@@ -683,22 +703,12 @@ static int __init etnaviv_init(void)
                if (!of_device_is_available(np))
                        continue;
 
-               pdev = platform_device_alloc("etnaviv", PLATFORM_DEVID_NONE);
-               if (!pdev) {
-                       ret = -ENOMEM;
-                       of_node_put(np);
-                       goto unregister_platform_driver;
-               }
+               of_node_put(np);
 
-               ret = platform_device_add(pdev);
-               if (ret) {
-                       platform_device_put(pdev);
-                       of_node_put(np);
+               ret = etnaviv_create_platform_device("etnaviv");
+               if (ret)
                        goto unregister_platform_driver;
-               }
 
-               etnaviv_drm = pdev;
-               of_node_put(np);
                break;
        }
 
-- 
2.25.1