Re: [PATCH] drm/fb-helper: Remove helpers to change frame buffer config

2023-04-04 Thread Geert Uytterhoeven
Hi Daniel, On Tue, Aug 9, 2022 at 5:03 PM Daniel Vetter wrote: > On Sat, Jul 02, 2022 at 08:05:54PM +0200, Helge Deller wrote: > > On 6/29/22 12:56, Geert Uytterhoeven wrote: > > > The DRM fbdev emulation layer does not support pushing back > > > changes to fb_var_screeninfo to KMS. > > > > > >

Re: [PATCH] drm/fb-helper: Remove helpers to change frame buffer config

2022-08-09 Thread Daniel Vetter
On Sat, Jul 02, 2022 at 08:05:54PM +0200, Helge Deller wrote: > On 6/29/22 12:56, Geert Uytterhoeven wrote: > > The DRM fbdev emulation layer does not support pushing back > > changes to fb_var_screeninfo to KMS. > > > > However, drm_fb_helper still implements the fb_ops.fb_check_var() and > >

Re: [PATCH] drm/fb-helper: Remove helpers to change frame buffer config

2022-07-04 Thread Helge Deller
On 6/29/22 12:56, Geert Uytterhoeven wrote: > The DRM fbdev emulation layer does not support pushing back > changes to fb_var_screeninfo to KMS. > > However, drm_fb_helper still implements the fb_ops.fb_check_var() and > fb_ops.fb_set_par() callbacks, but the former fails to validate various >

[PATCH] drm/fb-helper: Remove helpers to change frame buffer config

2022-06-29 Thread Geert Uytterhoeven
The DRM fbdev emulation layer does not support pushing back changes to fb_var_screeninfo to KMS. However, drm_fb_helper still implements the fb_ops.fb_check_var() and fb_ops.fb_set_par() callbacks, but the former fails to validate various parameters passed from userspace. Hence unsanitized and