Re: [PATCH] drm/fourcc: Fix undefined left shift in DRM_FORMAT_BIG_ENDIAN macros

2019-10-18 Thread Ville Syrjälä
On Fri, Oct 18, 2019 at 01:50:41PM -0400, Adam Jackson wrote: > 1<<31 is undefined because it's a signed int and C is terrible. > > Reviewed-by: Eric Engestrom > Signed-off-by: Adam Jackson Thanks. Pushed to drm-misc-next. > --- > include/uapi/drm/drm_fourcc.h | 2 +- > 1 file changed, 1

[PATCH] drm/fourcc: Fix undefined left shift in DRM_FORMAT_BIG_ENDIAN macros

2019-10-18 Thread Adam Jackson
1<<31 is undefined because it's a signed int and C is terrible. Reviewed-by: Eric Engestrom Signed-off-by: Adam Jackson --- include/uapi/drm/drm_fourcc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index

Re: [PATCH] drm/fourcc: Fix undefined left shift in DRM_FORMAT_BIG_ENDIAN macros

2019-10-18 Thread Ville Syrjälä
On Fri, Oct 18, 2019 at 12:39:26PM -0400, Adam Jackson wrote: > 1<<31 is undefined because it's a signed int and C is terrible. > > Reviewed-by: Eric Engestrom Missing teh sob. > --- > include/uapi/drm/drm_fourcc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH] drm/fourcc: Fix undefined left shift in DRM_FORMAT_BIG_ENDIAN macros

2019-10-18 Thread Adam Jackson
1<<31 is undefined because it's a signed int and C is terrible. Reviewed-by: Eric Engestrom --- include/uapi/drm/drm_fourcc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index 3feeaa3f987a..c06d34559fab 100644