At Thu, 13 Oct 2011 12:28:07 -0700,
Keith Packard wrote:
>
> On Thu, 13 Oct 2011 20:05:49 +0200, Takashi Iwai wrote:
>
> > Yes, this looks more understandable, indeed.
> > Would you patch it by yourself or should I refresh the patch?
> > In either way, I'll test tomorrow, as I'm already at home
At Thu, 13 Oct 2011 09:40:29 -0700,
Keith Packard wrote:
>
> On Thu, 13 Oct 2011 10:57:35 +0200, Takashi Iwai wrote:
>
> > This patch fixes the bug by recording the backlight level always
> > when changed but only when dev_priv->backlight_enabled is set.
> > In this way, the bogus value for
On Thu, 13 Oct 2011 20:05:49 +0200, Takashi Iwai wrote:
> Yes, this looks more understandable, indeed.
> Would you patch it by yourself or should I refresh the patch?
> In either way, I'll test tomorrow, as I'm already at home without a
> test machine.
I don't have time before Monday to look at
The commit 47356eb67285014527a5ab87543ba1fae3d1e10a introduced a
mechanism to record the backlight level only at disabling time, but it
also introduced a regression. Since intel_lvds_enable() may be called
without disabling (e.g. intel_lvds_commit() calls it unconditionally),
the backlight gets
On Thu, 13 Oct 2011 10:57:35 +0200, Takashi Iwai wrote:
> This patch fixes the bug by recording the backlight level always
> when changed but only when dev_priv->backlight_enabled is set.
> In this way, the bogus value for disabling backlight can be skipped.
I think this is better than what we
The commit 47356eb67285014527a5ab87543ba1fae3d1e10a introduced a
mechanism to record the backlight level only at disabling time, but it
also introduced a regression. Since intel_lvds_enable() may be called
without disabling (e.g. intel_lvds_commit() calls it unconditionally),
the backlight gets
On Thu, 13 Oct 2011 10:57:35 +0200, Takashi Iwai ti...@suse.de wrote:
This patch fixes the bug by recording the backlight level always
when changed but only when dev_priv-backlight_enabled is set.
In this way, the bogus value for disabling backlight can be skipped.
I think this is better than
At Thu, 13 Oct 2011 09:40:29 -0700,
Keith Packard wrote:
On Thu, 13 Oct 2011 10:57:35 +0200, Takashi Iwai ti...@suse.de wrote:
This patch fixes the bug by recording the backlight level always
when changed but only when dev_priv-backlight_enabled is set.
In this way, the bogus value for
On Thu, 13 Oct 2011 20:05:49 +0200, Takashi Iwai ti...@suse.de wrote:
Yes, this looks more understandable, indeed.
Would you patch it by yourself or should I refresh the patch?
In either way, I'll test tomorrow, as I'm already at home without a
test machine.
I don't have time before Monday
At Thu, 13 Oct 2011 12:28:07 -0700,
Keith Packard wrote:
On Thu, 13 Oct 2011 20:05:49 +0200, Takashi Iwai ti...@suse.de wrote:
Yes, this looks more understandable, indeed.
Would you patch it by yourself or should I refresh the patch?
In either way, I'll test tomorrow, as I'm already at
10 matches
Mail list logo