Re: [PATCH] drm/i9i5/gt: Fix a double free in gen8_preallocate_top_level_pdp

2021-04-27 Thread Matthew Auld
On Mon, 26 Apr 2021 at 13:44, Lv Yunlong wrote: > > Our code analyzer reported a double free bug. > > In gen8_preallocate_top_level_pdp, pde and pde->pt.base are allocated > via alloc_pd(vm) with one reference. If pin_pt_dma() failed, pde->pt.base > is freed by i915_gem_object_put() with a referen

[PATCH] drm/i9i5/gt: Fix a double free in gen8_preallocate_top_level_pdp

2021-04-26 Thread Lv Yunlong
Our code analyzer reported a double free bug. In gen8_preallocate_top_level_pdp, pde and pde->pt.base are allocated via alloc_pd(vm) with one reference. If pin_pt_dma() failed, pde->pt.base is freed by i915_gem_object_put() with a reference dropped. Then free_pd calls free_px() defined in intel_pp