Re: [PATCH] drm/meson: Fix refcount bugs in meson_vpu_has_available_connectors()

2022-08-08 Thread Neil Armstrong
Hi, On Tue, 26 Jul 2022 09:07:22 +0800, Liang He wrote: > In this function, there are two refcount leak bugs: > (1) when breaking out of for_each_endpoint_of_node(), we need call > the of_node_put() for the 'ep'; > (2) we should call of_node_put() for the reference returned by >

Re: [PATCH] drm/meson: Fix refcount bugs in meson_vpu_has_available_connectors()

2022-08-08 Thread Neil Armstrong
On 26/07/2022 03:07, Liang He wrote: In this function, there are two refcount leak bugs: (1) when breaking out of for_each_endpoint_of_node(), we need call the of_node_put() for the 'ep'; (2) we should call of_node_put() for the reference returned by of_graph_get_remote_port() when it is not

[PATCH] drm/meson: Fix refcount bugs in meson_vpu_has_available_connectors()

2022-07-25 Thread Liang He
In this function, there are two refcount leak bugs: (1) when breaking out of for_each_endpoint_of_node(), we need call the of_node_put() for the 'ep'; (2) we should call of_node_put() for the reference returned by of_graph_get_remote_port() when it is not used anymore. Fixes: bbbe775ec5b5 ("drm:

Re:Re: [PATCH] drm/meson: Fix refcount bugs in meson_vpu_has_available_connectors()

2022-07-25 Thread Liang He
At 2022-07-26 03:39:17, "Martin Blumenstingl" wrote: >Hello, > >On Fri, Jul 15, 2022 at 3:22 PM Liang He wrote: >> >> In this function, there are two refcount leak bugs: >> (1) when breaking out of for_each_endpoint_of_node(), we need call >> the of_node_put() for the 'ep'; >> (2) we should

Re: [PATCH] drm/meson: Fix refcount bugs in meson_vpu_has_available_connectors()

2022-07-25 Thread Martin Blumenstingl
Hello, On Fri, Jul 15, 2022 at 3:22 PM Liang He wrote: > > In this function, there are two refcount leak bugs: > (1) when breaking out of for_each_endpoint_of_node(), we need call > the of_node_put() for the 'ep'; > (2) we should call of_node_put() for the reference returned by >

[PATCH] drm/meson: Fix refcount bugs in meson_vpu_has_available_connectors()

2022-07-16 Thread Liang He
In this function, there are two refcount leak bugs: (1) when breaking out of for_each_endpoint_of_node(), we need call the of_node_put() for the 'ep'; (2) we should call of_node_put() for the reference returned by of_graph_get_remote_port() when it is not used anymore. Fixes: bbbe775ec5b5 ("drm: