Re: [PATCH] drm/mgag200: set variable mgag200_modeset storage-class-specifier to static

2023-06-23 Thread Jocelyn Falempe
On 23/06/2023 10:28, Thomas Zimmermann wrote: Am 17.05.23 um 15:41 schrieb Tom Rix: smatch reports drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol    'mgag200_modeset' was not declared. Should it be static? This variable is only used in its defining file, so it should be static

Re: [PATCH] drm/mgag200: set variable mgag200_modeset storage-class-specifier to static

2023-06-23 Thread Thomas Zimmermann
Am 17.05.23 um 15:41 schrieb Tom Rix: smatch reports drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol 'mgag200_modeset' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by: Tom Rix Reviewed-by: Thomas

Re: [PATCH] drm/mgag200: set variable mgag200_modeset storage-class-specifier to static

2023-05-23 Thread Jocelyn Falempe
On 17/05/2023 15:41, Tom Rix wrote: smatch reports drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol 'mgag200_modeset' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by: Tom Rix ---

[PATCH] drm/mgag200: set variable mgag200_modeset storage-class-specifier to static

2023-05-17 Thread Tom Rix
smatch reports drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol 'mgag200_modeset' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by: Tom Rix --- drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +- 1 file changed,