Re: [PATCH] drm/msm/dpu: Add check for cstate

2023-01-26 Thread Dmitry Baryshkov
On Tue, 06 Dec 2022 16:05:17 +0800, Jiasheng Jiang wrote: > As kzalloc may fail and return NULL pointer, > it should be better to check cstate > in order to avoid the NULL pointer dereference > in __drm_atomic_helper_crtc_reset. > > Applied, thanks! [1/1] drm/msm/dpu: Add check for cstate

Re: [PATCH] drm/msm/dpu: Add check for cstate

2023-01-08 Thread Dmitry Baryshkov
On 08/01/2023 23:56, Dmitry Baryshkov wrote: On 06/12/2022 10:05, Jiasheng Jiang wrote: As kzalloc may fail and return NULL pointer, it should be better to check cstate in order to avoid the NULL pointer dereference in __drm_atomic_helper_crtc_reset. Fixes: 1cff7440a86e ("drm/msm: Convert to us

Re: [PATCH] drm/msm/dpu: Add check for cstate

2023-01-08 Thread Dmitry Baryshkov
On 06/12/2022 10:05, Jiasheng Jiang wrote: As kzalloc may fail and return NULL pointer, it should be better to check cstate in order to avoid the NULL pointer dereference in __drm_atomic_helper_crtc_reset. Fixes: 1cff7440a86e ("drm/msm: Convert to using __drm_atomic_helper_crtc_reset() for rese

Re: [PATCH] drm/msm/dpu: Add check for cstate

2022-12-06 Thread Abhinav Kumar
On 12/6/2022 12:05 AM, Jiasheng Jiang wrote: As kzalloc may fail and return NULL pointer, it should be better to check cstate in order to avoid the NULL pointer dereference in __drm_atomic_helper_crtc_reset. You have wrapped around your lines too short. Please try to utilize the full word l

[PATCH] drm/msm/dpu: Add check for cstate

2022-12-06 Thread Jiasheng Jiang
As kzalloc may fail and return NULL pointer, it should be better to check cstate in order to avoid the NULL pointer dereference in __drm_atomic_helper_crtc_reset. Fixes: 1cff7440a86e ("drm/msm: Convert to using __drm_atomic_helper_crtc_reset() for reset.") Signed-off-by: Jiasheng Jiang --- driv

[PATCH] drm/msm/dpu: Add check for cstate

2022-12-06 Thread Jiasheng Jiang
As kzalloc may fail and return NULL pointer, it should be better to check pstates in order to avoid the NULL pointer dereference later. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Jiasheng Jiang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 ++ 1 file changed, 2 ins