Re: [PATCH] drm/msm: dpu: Don't enable vblank interrupts in irq_control

2018-12-07 Thread Abhinav Kumar
On 2018-12-07 13:50, Sean Paul wrote: On Fri, Dec 07, 2018 at 01:16:54PM -0800, Abhinav Kumar wrote: On 2018-12-07 09:16, Sean Paul wrote: > From: Sean Paul > > The irq_control function is called upon encoder enable/disable and turns > on/off the vblank interrupts. Unfortunately, it enables the

Re: [PATCH] drm/msm: dpu: Don't enable vblank interrupts in irq_control

2018-12-07 Thread Sean Paul
On Fri, Dec 07, 2018 at 01:16:54PM -0800, Abhinav Kumar wrote: > On 2018-12-07 09:16, Sean Paul wrote: > > From: Sean Paul > > > > The irq_control function is called upon encoder enable/disable and turns > > on/off the vblank interrupts. Unfortunately, it enables them when the > > drm code is not

Re: [PATCH] drm/msm: dpu: Don't enable vblank interrupts in irq_control

2018-12-07 Thread Abhinav Kumar
On 2018-12-07 09:16, Sean Paul wrote: From: Sean Paul The irq_control function is called upon encoder enable/disable and turns on/off the vblank interrupts. Unfortunately, it enables them when the drm code is not expecting them to be on. As a result, we can get into nasty locking situations.

[PATCH] drm/msm: dpu: Don't enable vblank interrupts in irq_control

2018-12-07 Thread Sean Paul
From: Sean Paul The irq_control function is called upon encoder enable/disable and turns on/off the vblank interrupts. Unfortunately, it enables them when the drm code is not expecting them to be on. As a result, we can get into nasty locking situations. vblank interrupts should be solely manage