Re: [PATCH] drm/nouveau/mmu: fix Use after Free bug in nvkm_vmm_node_split

2023-01-28 Thread Takashi Iwai
On Sat, 28 Jan 2023 03:17:15 +0100, Danilo Krummrich wrote: > > On Fri, Jan 27, 2023 at 01:10:46PM +0100, Takashi Iwai wrote: > > On Tue, 03 Jan 2023 15:07:55 +0100, > > Takashi Iwai wrote: > > > > > > On Fri, 30 Dec 2022 08:27:58 +0100, > > > Zheng Wang wrote: > > > > > > > > Here is a

Re: [PATCH] drm/nouveau/mmu: fix Use after Free bug in nvkm_vmm_node_split

2023-01-27 Thread Danilo Krummrich
On Fri, Jan 27, 2023 at 01:10:46PM +0100, Takashi Iwai wrote: > On Tue, 03 Jan 2023 15:07:55 +0100, > Takashi Iwai wrote: > > > > On Fri, 30 Dec 2022 08:27:58 +0100, > > Zheng Wang wrote: > > > > > > Here is a function call chain. > > >

Re: [PATCH] drm/nouveau/mmu: fix Use after Free bug in nvkm_vmm_node_split

2023-01-27 Thread Takashi Iwai
On Tue, 03 Jan 2023 15:07:55 +0100, Takashi Iwai wrote: > > On Fri, 30 Dec 2022 08:27:58 +0100, > Zheng Wang wrote: > > > > Here is a function call chain. > > nvkm_vmm_pfn_map->nvkm_vmm_pfn_split_merge->nvkm_vmm_node_split > > If nvkm_vma_tail return NULL in nvkm_vmm_node_split, it will > >

Re: [PATCH] drm/nouveau/mmu: fix Use after Free bug in nvkm_vmm_node_split

2023-01-03 Thread Takashi Iwai
On Fri, 30 Dec 2022 08:27:58 +0100, Zheng Wang wrote: > > Here is a function call chain. > nvkm_vmm_pfn_map->nvkm_vmm_pfn_split_merge->nvkm_vmm_node_split > If nvkm_vma_tail return NULL in nvkm_vmm_node_split, it will > finally invoke nvkm_vmm_node_merge->nvkm_vmm_node_delete, which > will free

[PATCH] drm/nouveau/mmu: fix Use after Free bug in nvkm_vmm_node_split

2022-12-29 Thread Zheng Wang
Here is a function call chain. nvkm_vmm_pfn_map->nvkm_vmm_pfn_split_merge->nvkm_vmm_node_split If nvkm_vma_tail return NULL in nvkm_vmm_node_split, it will finally invoke nvkm_vmm_node_merge->nvkm_vmm_node_delete, which will free the vma. However, nvkm_vmm_pfn_map didn't notice that. It goes into