[PATCH] drm/nouveau: usif_ioctl: ensure returns are initialized

2015-07-01 Thread Emil Velikov
On 1 July 2015 at 18:37, Ilia Mirkin wrote: > On Wed, Jul 1, 2015 at 1:18 PM, Colin Ian King > wrote: >> On 01/07/15 18:12, Emil Velikov wrote: >>> On 1 July 2015 at 17:56, Ilia Mirkin wrote: On Wed, Jul 1, 2015 at 12:51 PM, Colin King wrote: > From: Colin Ian King > >

[PATCH] drm/nouveau: usif_ioctl: ensure returns are initialized

2015-07-01 Thread Colin Ian King
On 01/07/15 18:12, Emil Velikov wrote: > On 1 July 2015 at 17:56, Ilia Mirkin wrote: >> On Wed, Jul 1, 2015 at 12:51 PM, Colin King >> wrote: >>> From: Colin Ian King >>> >>> Various usif_ioctl helper functions do not initialize the >>> return variable ret and some of the error handling return

[PATCH] drm/nouveau: usif_ioctl: ensure returns are initialized

2015-07-01 Thread Emil Velikov
On 1 July 2015 at 17:56, Ilia Mirkin wrote: > On Wed, Jul 1, 2015 at 12:51 PM, Colin King > wrote: >> From: Colin Ian King >> >> Various usif_ioctl helper functions do not initialize the >> return variable ret and some of the error handling return >> paths just return garbage values that were

[PATCH] drm/nouveau: usif_ioctl: ensure returns are initialized

2015-07-01 Thread Colin King
From: Colin Ian King Various usif_ioctl helper functions do not initialize the return variable ret and some of the error handling return paths just return garbage values that were on the stack (or in a register). I believe that in all the cases, the initial ret

[PATCH] drm/nouveau: usif_ioctl: ensure returns are initialized

2015-07-01 Thread Ilia Mirkin
On Wed, Jul 1, 2015 at 1:59 PM, Emil Velikov wrote: > On 1 July 2015 at 18:37, Ilia Mirkin wrote: >> On Wed, Jul 1, 2015 at 1:18 PM, Colin Ian King >> wrote: >>> On 01/07/15 18:12, Emil Velikov wrote: On 1 July 2015 at 17:56, Ilia Mirkin wrote: > On Wed, Jul 1, 2015 at 12:51 PM,

[PATCH] drm/nouveau: usif_ioctl: ensure returns are initialized

2015-07-01 Thread Ilia Mirkin
On Wed, Jul 1, 2015 at 1:18 PM, Colin Ian King wrote: > On 01/07/15 18:12, Emil Velikov wrote: >> On 1 July 2015 at 17:56, Ilia Mirkin wrote: >>> On Wed, Jul 1, 2015 at 12:51 PM, Colin King >>> wrote: From: Colin Ian King Various usif_ioctl helper functions do not initialize

[PATCH] drm/nouveau: usif_ioctl: ensure returns are initialized

2015-07-01 Thread Ilia Mirkin
On Wed, Jul 1, 2015 at 12:51 PM, Colin King wrote: > From: Colin Ian King > > Various usif_ioctl helper functions do not initialize the > return variable ret and some of the error handling return > paths just return garbage values that were on the stack (or > in a register). I believe that in