Re: [PATCH] drm/panel: samsung: s6e8aa0: Add backlight control support

2020-04-06 Thread Joonas Kylmälä
Hi, addressing this email to you all since there might be widespread race condition issue in the DRM panel drivers that are using MIPI DSI. See below for my message. Andrzej Hajda: >> +static int s6e8aa0_set_brightness(struct backlight_device *bd) >> +{ >> +struct s6e8aa0 *ctx =

Re: [PATCH] drm/panel: samsung: s6e8aa0: Add backlight control support

2020-04-05 Thread Sam Ravnborg
Hi Joonas. On Sat, Apr 04, 2020 at 04:27:02PM +0300, Joonas Kylmälä wrote: > Hi, > > addressing this email to you all since there might be widespread race > condition issue in the DRM panel drivers that are using MIPI DSI. See > below for my message. > > Andrzej Hajda: > >> +static int

Re: [PATCH] drm/panel: samsung: s6e8aa0: Add backlight control support

2020-04-05 Thread Daniel Vetter
On Sat, Apr 4, 2020 at 3:27 PM Joonas Kylmälä wrote: > > Hi, > > addressing this email to you all since there might be widespread race > condition issue in the DRM panel drivers that are using MIPI DSI. See > below for my message. > > Andrzej Hajda: > >> +static int s6e8aa0_set_brightness(struct

Re: [PATCH] drm/panel: samsung: s6e8aa0: Add backlight control support

2019-09-23 Thread Joonas Kylmälä
Hi, thanks a lot for the review, Andrzej! Andrzej Hajda: >> +static const struct backlight_ops s6e8aa0_backlight_ops = { >> +.update_status = s6e8aa0_set_brightness, > > > This is racy, update_status can be called in any time between probe and > remove, particularly: > > a) before panel

Re: [PATCH] drm/panel: samsung: s6e8aa0: Add backlight control support

2019-09-23 Thread Andrzej Hajda
Hi Joonas, On 21.09.2019 14:48, Joonas Kylmälä wrote: > This makes the backlight brightness controllable from the > userspace. > > Signed-off-by: Joonas Kylmälä > --- > drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c | 82 > --- > 1 file changed, 60 insertions(+), 22

[PATCH] drm/panel: samsung: s6e8aa0: Add backlight control support

2019-09-21 Thread Joonas Kylmälä
This makes the backlight brightness controllable from the userspace. Signed-off-by: Joonas Kylmälä --- drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c | 82 --- 1 file changed, 60 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c