[PATCH] drm/radeon: Add early unregister of firmware fb's

Hi Dave, This hasn't shown up in one of your branches, yet. Do you want me to change something or was this patch simply lost somewhere? Thanks, Daniel On Wed, Oct 06, 2010 at 06:39:07PM +0200, Daniel Vetter wrote: > From: Benjamin Herrenschmidt > > Without this, we attempt the handover too

Re: [PATCH] drm/radeon: Add early unregister of firmware fb's

Hi Dave, This hasn't shown up in one of your branches, yet. Do you want me to change something or was this patch simply lost somewhere? Thanks, Daniel On Wed, Oct 06, 2010 at 06:39:07PM +0200, Daniel Vetter wrote: From: Benjamin Herrenschmidt b...@kernel.crashing.org Without this, we

[PATCH] drm/radeon: Add early unregister of firmware fb's

On Wed, Oct 06, 2010 at 08:54:12PM +0200, Daniel Vetter wrote: > On Wed, Oct 06, 2010 at 08:20:15PM +0200, Marcin Slusarz wrote: > > On Wed, Oct 06, 2010 at 06:39:07PM +0200, Daniel Vetter wrote: > > > +static void radeon_kick_out_firmware_fb(struct drm_device *ddev) > > > +{ > > > + struct

[PATCH] drm/radeon: Add early unregister of firmware fb's

On Wed, Oct 06, 2010 at 08:20:15PM +0200, Marcin Slusarz wrote: > On Wed, Oct 06, 2010 at 06:39:07PM +0200, Daniel Vetter wrote: > > +static void radeon_kick_out_firmware_fb(struct drm_device *ddev) > > +{ > > + struct apertures_struct *ap; > > + bool primary = false; > > + > > + ap =

[PATCH] drm/radeon: Add early unregister of firmware fb's

On Wed, Oct 06, 2010 at 06:39:07PM +0200, Daniel Vetter wrote: > From: Benjamin Herrenschmidt > > Without this, we attempt the handover too late, the firmware fb > might be accessing the chip simultaneously to us re-initializing > various parts of it, which might frighten babies or cause all

[PATCH] drm/radeon: Add early unregister of firmware fb's

From: Benjamin Herrenschmidt Without this, we attempt the handover too late, the firmware fb might be accessing the chip simultaneously to us re-initializing various parts of it, which might frighten babies or cause all sort of nasty psychologic trauma to kitten. Cc:

Re: [PATCH] drm/radeon: Add early unregister of firmware fb's

On Wed, Oct 06, 2010 at 08:20:15PM +0200, Marcin Slusarz wrote: On Wed, Oct 06, 2010 at 06:39:07PM +0200, Daniel Vetter wrote: +static void radeon_kick_out_firmware_fb(struct drm_device *ddev) +{ + struct apertures_struct *ap; + bool primary = false; + + ap = alloc_apertures(1);

[PATCH] drm/radeon: Add early unregister of firmware fb's

On Mon, 2010-08-16 at 09:00 +0200, Rafa? Mi?ecki wrote: > 2010/8/10 Benjamin Herrenschmidt : > > +#ifdef CONFIG_X86 > > + primary = dev->pdev->resource[PCI_ROM_RESOURCE].flags & > IORESOURCE_ROM_SHADOW; > > +#endif > > It won't compile for CONFIG_X86, no "dev". Ah right, I've done more

[PATCH] drm/radeon: Add early unregister of firmware fb's

2010/8/10 Benjamin Herrenschmidt : > +#ifdef CONFIG_X86 > + ? ? ? primary = dev->pdev->resource[PCI_ROM_RESOURCE].flags & > IORESOURCE_ROM_SHADOW; > +#endif It won't compile for CONFIG_X86, no "dev". -- Rafa?

Re: [PATCH] drm/radeon: Add early unregister of firmware fb's

2010/8/10 Benjamin Herrenschmidt b...@kernel.crashing.org: +#ifdef CONFIG_X86 +       primary = dev-pdev-resource[PCI_ROM_RESOURCE].flags IORESOURCE_ROM_SHADOW; +#endif It won't compile for CONFIG_X86, no dev. -- Rafał ___ dri-devel mailing list

Re: [PATCH] drm/radeon: Add early unregister of firmware fb's

On Mon, 2010-08-16 at 09:00 +0200, Rafał Miłecki wrote: 2010/8/10 Benjamin Herrenschmidt b...@kernel.crashing.org: +#ifdef CONFIG_X86 + primary = dev-pdev-resource[PCI_ROM_RESOURCE].flags IORESOURCE_ROM_SHADOW; +#endif It won't compile for CONFIG_X86, no dev. Ah right, I've done

[PATCH] drm/radeon: Add early unregister of firmware fb's

Without this, we attempt the handover too late, the firmware fb might be accessing the chip simultaneously to us re-initializing various parts of it, which might frighten babies or cause all sort of nasty psychologic trauma to kitten. Signed-off-by: Benjamin Herrenschmidt ---

[PATCH] drm/radeon: Add early unregister of firmware fb's

Without this, we attempt the handover too late, the firmware fb might be accessing the chip simultaneously to us re-initializing various parts of it, which might frighten babies or cause all sort of nasty psychologic trauma to kitten. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org