Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Tom Rix
On 4/4/22 6:32 AM, Christian König wrote: Am 04.04.22 um 15:01 schrieb Tom Rix: On 4/4/22 5:34 AM, Christian König wrote: Am 04.04.22 um 14:32 schrieb Tom Rix: On 4/3/22 8:23 AM, Christian König wrote: Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues

Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Christian König
Am 04.04.22 um 15:01 schrieb Tom Rix: On 4/4/22 5:34 AM, Christian König wrote: Am 04.04.22 um 14:32 schrieb Tom Rix: On 4/3/22 8:23 AM, Christian König wrote: Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state'    was

Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Tom Rix
On 4/4/22 5:34 AM, Christian König wrote: Am 04.04.22 um 14:32 schrieb Tom Rix: On 4/3/22 8:23 AM, Christian König wrote: Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state'    was not declared. Should it be static?

Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Christian König
Am 04.04.22 um 14:32 schrieb Tom Rix: On 4/3/22 8:23 AM, Christian König wrote: Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state'    was not declared. Should it be static? si_blit_shaders.c:253:11: warning: symbol

Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-04 Thread Tom Rix
On 4/3/22 8:23 AM, Christian König wrote: Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state'    was not declared. Should it be static? si_blit_shaders.c:253:11: warning: symbol 'si_default_size'    was not declared.

Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-03 Thread Christian König
Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state' was not declared. Should it be static? si_blit_shaders.c:253:11: warning: symbol 'si_default_size' was not declared. Should it be static? Both symbols are only

[PATCH] drm/radeon: change si_default_state table from global to static

2022-04-02 Thread Tom Rix
Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state' was not declared. Should it be static? si_blit_shaders.c:253:11: warning: symbol 'si_default_size' was not declared. Should it be static? Both symbols are only used in si.c. Single file symbols should be