Re: [PATCH] drm/simple-kms: Standardize arguments for callbacks

On Wed, Oct 23, 2019 at 05:40:32PM +0200, Linus Walleij wrote: > On Wed, Oct 23, 2019 at 12:13 PM Daniel Vetter wrote: > > > Passing the wrong type feels icky, everywhere else we use the pipe as > > the first parameter. Spotted while discussing patches with Thomas > > Zimmermann. > > > > v2:

Re: [PATCH] drm/simple-kms: Standardize arguments for callbacks

On Wed, Oct 23, 2019 at 12:13 PM Daniel Vetter wrote: > Passing the wrong type feels icky, everywhere else we use the pipe as > the first parameter. Spotted while discussing patches with Thomas > Zimmermann. > > v2: Make xen compile correctly > > Acked-By: Thomas Zimmermann (v1) > Cc: Thomas

[PATCH] drm/simple-kms: Standardize arguments for callbacks

Passing the wrong type feels icky, everywhere else we use the pipe as the first parameter. Spotted while discussing patches with Thomas Zimmermann. v2: Make xen compile correctly Acked-By: Thomas Zimmermann (v1) Cc: Thomas Zimmermann Cc: Noralf Trønnes Cc: Gerd Hoffmann Cc: Eric Anholt Cc:

Re: [PATCH] drm/simple-kms: Standardize arguments for callbacks

On Wed, Oct 23, 2019 at 08:47:57AM +0200, Thomas Zimmermann wrote: > Hi > > Am 22.10.19 um 21:03 schrieb Daniel Vetter: > > On Tue, Oct 22, 2019 at 7:16 PM Thomas Zimmermann > > wrote: > >> > >> Hi, > >> > >> there are two types of callbacks in struct > >> drm_simple_display_pipe_funcs:

Re: [PATCH] drm/simple-kms: Standardize arguments for callbacks

Hi Am 22.10.19 um 21:03 schrieb Daniel Vetter: > On Tue, Oct 22, 2019 at 7:16 PM Thomas Zimmermann wrote: >> >> Hi, >> >> there are two types of callbacks in struct >> drm_simple_display_pipe_funcs: functions that are genuine to simple KMS, >> and functions that are merely forwarded from another

Re: [PATCH] drm/simple-kms: Standardize arguments for callbacks

Hi Daniel, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.4-rc4 next-20191022] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify

Re: [PATCH] drm/simple-kms: Standardize arguments for callbacks

Hi Daniel, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.4-rc4 next-20191022] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the

Re: [PATCH] drm/simple-kms: Standardize arguments for callbacks

On Tue, Oct 22, 2019 at 7:16 PM Thomas Zimmermann wrote: > > Hi, > > there are two types of callbacks in struct > drm_simple_display_pipe_funcs: functions that are genuine to simple KMS, > and functions that are merely forwarded from another structure (crtc, > plane, etc). > > In the former

Re: [PATCH] drm/simple-kms: Standardize arguments for callbacks

Hi, there are two types of callbacks in struct drm_simple_display_pipe_funcs: functions that are genuine to simple KMS, and functions that are merely forwarded from another structure (crtc, plane, etc). In the former category are enable(), disable(), check(), and update(). Those should probably

[PATCH] drm/simple-kms: Standardize arguments for callbacks

Passing the wrong type feels icky, everywhere else we use the pipe as the first parameter. Spotted while discussing patches with Thomas Zimmermann. Cc: Thomas Zimmermann Cc: Noralf Trønnes Cc: Gerd Hoffmann Cc: Eric Anholt Cc: Emil Velikov Cc: virtualizat...@lists.linux-foundation.org Cc: