Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

te->visible && crtc_state->enable makes WARN_ON to fire always. So, probably we may want removing it. Thanks, Daniel Thank you, Oleksandr  From dbcce708b237740158a2c16029c56a579324f269 Mon Sep 17 00:00:00 2001 From: Oleksandr Andrushchenko <oleksandr_andrushche...@epam.com> Date: Tue, 13 Feb

Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

   18.940048] vdispl vdispl.0: [drm] > > > > src-pos=0.00x0.00+0.00+0.00 > > > > [   18.940067] vdispl vdispl.0: [drm]   rotation=1 > > > > [   18.940199] [drm:drm_atomic_check_only [drm]] checking > > > > 00000bc224e7 > > > > [ 

Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

nce, so we need a check for that. Yet, !plane_state->visible && crtc_state->enable makes WARN_ON to fire always. So, probably we may want removing it. Thanks, Daniel Thank you, Oleksandr  From dbcce708b237740158a2c16029c56a579324f269 Mon Sep 17 00:00:00 2001 From: Oleksandr Andrushchenko

Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

check for that. Yet, !plane_state->visible && crtc_state->enable makes WARN_ON to fire always. So, probably we may want removing it. Thanks, Daniel Thank you, Oleksandr From dbcce708b237740158a2c16029c56a579324f269 Mon Sep 17 00:00:00 2001 From: Oleksandr Andrushchenko <oleks

Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

ne-31] on [CRTC:30:crtc-0] > [   18.979960] [drm:drm_atomic_helper_check_modeset [drm_kms_helper]] > [CRTC:30:crtc-0] needs all connectors, enable: y, active: y > [   18.980139] [drm:drm_atomic_add_affected_connectors [drm]] Adding all > current connectors for [CRTC:30:crtc-0] to

Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

check for that. Yet, !plane_state->visible && crtc_state->enable makes WARN_ON to fire always. So, probably we may want removing it. Thanks, Daniel Thank you, Oleksandr >From dbcce708b237740158a2c16029c56a579324f269 Mon Sep 17 00:00:00 2001 From: Oleksandr Andrushchenko <oleksan

Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

On Mon, Feb 19, 2018 at 04:58:43PM +0200, Oleksandr Andrushchenko wrote: > On 02/19/2018 04:30 PM, Daniel Vetter wrote: > > On Tue, Feb 13, 2018 at 10:44:16AM +0200, Oleksandr Andrushchenko wrote: > > > From: Oleksandr Andrushchenko > > > > > > It is possible

Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

On 02/19/2018 04:30 PM, Daniel Vetter wrote: On Tue, Feb 13, 2018 at 10:44:16AM +0200, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko It is possible that drm_simple_kms_plane_atomic_check called with no CRTC set, e.g. when user-space application

Re: [PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

On Tue, Feb 13, 2018 at 10:44:16AM +0200, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > It is possible that drm_simple_kms_plane_atomic_check called > with no CRTC set, e.g. when user-space application sets CRTC_ID/FB_ID > to 0 before doing

[PATCH] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

From: Oleksandr Andrushchenko It is possible that drm_simple_kms_plane_atomic_check called with no CRTC set, e.g. when user-space application sets CRTC_ID/FB_ID to 0 before doing any actual drawing. This leads to NULL pointer dereference because in this case new