"Maxime Ripard" writes:
> On Thu, 14 Sep 2023 21:51:24 +0200, Javier Martinez Canillas wrote:
>> The driver uses a naming convention where functions for struct drm_*_funcs
>> callbacks are named ssd130x_$object_$operation, while the callbacks for
>> struct drm_*_helper_funcs are named
On Thu, 14 Sep 2023 21:51:24 +0200, Javier Martinez Canillas wrote:
> The driver uses a naming convention where functions for struct drm_*_funcs
> callbacks are named ssd130x_$object_$operation, while the callbacks for
> struct drm_*_helper_funcs are named ssd130x_$object_helper_$operation.
>
>
Hi,
On Thu, Sep 21, 2023 at 10:52:14AM +0200, Thomas Zimmermann wrote:
> Am 21.09.23 um 09:44 schrieb Maxime Ripard:
> > On Mon, Sep 18, 2023 at 09:19:07AM +0200, Javier Martinez Canillas wrote:
> > > Thomas Zimmermann writes:
> > >
> > > > Hi
> > > >
> > > > Am 14.09.23 um 21:51 schrieb
Hi Maxime,
On Thu, Sep 21, 2023 at 10:51 AM Maxime Ripard wrote:
> On Thu, Sep 21, 2023 at 10:46:05AM +0200, Geert Uytterhoeven wrote:
> > On Thu, Sep 21, 2023 at 10:12 AM Maxime Ripard wrote:
> > > On Thu, Sep 21, 2023 at 09:57:22AM +0200, Geert Uytterhoeven wrote:
> > > > On Thu, Sep 21, 2023
Hi
Am 21.09.23 um 10:46 schrieb Geert Uytterhoeven:
[...]
Anything else confuses the casual reader. Perhaps the real question is whether
the structures should have "helper" in their name in the first place?
Those structures are meant for functions used by the helpers, they are not
helper
Hi
Am 21.09.23 um 09:44 schrieb Maxime Ripard:
Hi,
On Mon, Sep 18, 2023 at 09:19:07AM +0200, Javier Martinez Canillas wrote:
Thomas Zimmermann writes:
Hi
Am 14.09.23 um 21:51 schrieb Javier Martinez Canillas:
The driver uses a naming convention where functions for struct drm_*_funcs
On Thu, Sep 21, 2023 at 10:46:05AM +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 21, 2023 at 10:12 AM Maxime Ripard wrote:
> > On Thu, Sep 21, 2023 at 09:57:22AM +0200, Geert Uytterhoeven wrote:
> > > On Thu, Sep 21, 2023 at 9:44 AM Maxime Ripard wrote:
> > > > On Mon, Sep 18, 2023 at
Hi Maxime,
On Thu, Sep 21, 2023 at 10:12 AM Maxime Ripard wrote:
> On Thu, Sep 21, 2023 at 09:57:22AM +0200, Geert Uytterhoeven wrote:
> > On Thu, Sep 21, 2023 at 9:44 AM Maxime Ripard wrote:
> > > On Mon, Sep 18, 2023 at 09:19:07AM +0200, Javier Martinez Canillas wrote:
> > > > Thomas
Hi
Am 21.09.23 um 10:23 schrieb Javier Martinez Canillas:
[...]
Both options have cons and pros (e.g: quickly figuring out to what struct
callback is associated as you said), but the reason I posted this patch is
to attempt making the driver more consistent with the rest of the drivers.
Maxime Ripard writes:
> On Thu, Sep 21, 2023 at 09:57:22AM +0200, Geert Uytterhoeven wrote:
[...]
>> Anything else confuses the casual reader. Perhaps the real question is
>> whether
>> the structures should have "helper" in their name in the first place?
>
> Those structures are meant for
Geert Uytterhoeven writes:
Hello Geert and Maxime,
> Hi Maxime,
>
> On Thu, Sep 21, 2023 at 9:44 AM Maxime Ripard wrote:
>> On Mon, Sep 18, 2023 at 09:19:07AM +0200, Javier Martinez Canillas wrote:
>> > Thomas Zimmermann writes:
>> > > Am 14.09.23 um 21:51 schrieb Javier Martinez Canillas:
>>
On Thu, Sep 21, 2023 at 09:57:22AM +0200, Geert Uytterhoeven wrote:
> Hi Maxime,
>
> On Thu, Sep 21, 2023 at 9:44 AM Maxime Ripard wrote:
> > On Mon, Sep 18, 2023 at 09:19:07AM +0200, Javier Martinez Canillas wrote:
> > > Thomas Zimmermann writes:
> > > > Am 14.09.23 um 21:51 schrieb Javier
Hi Maxime,
On Thu, Sep 21, 2023 at 9:44 AM Maxime Ripard wrote:
> On Mon, Sep 18, 2023 at 09:19:07AM +0200, Javier Martinez Canillas wrote:
> > Thomas Zimmermann writes:
> > > Am 14.09.23 um 21:51 schrieb Javier Martinez Canillas:
> > >> The driver uses a naming convention where functions for
Hi,
On Mon, Sep 18, 2023 at 09:19:07AM +0200, Javier Martinez Canillas wrote:
> Thomas Zimmermann writes:
>
> > Hi
> >
> > Am 14.09.23 um 21:51 schrieb Javier Martinez Canillas:
> >> The driver uses a naming convention where functions for struct drm_*_funcs
> >> callbacks are named
Thomas Zimmermann writes:
> Hi
>
> Am 14.09.23 um 21:51 schrieb Javier Martinez Canillas:
>> The driver uses a naming convention where functions for struct drm_*_funcs
>> callbacks are named ssd130x_$object_$operation, while the callbacks for
>> struct drm_*_helper_funcs are named
Hi
Am 14.09.23 um 21:51 schrieb Javier Martinez Canillas:
The driver uses a naming convention where functions for struct drm_*_funcs
callbacks are named ssd130x_$object_$operation, while the callbacks for
struct drm_*_helper_funcs are named ssd130x_$object_helper_$operation.
The idea is that
The driver uses a naming convention where functions for struct drm_*_funcs
callbacks are named ssd130x_$object_$operation, while the callbacks for
struct drm_*_helper_funcs are named ssd130x_$object_helper_$operation.
The idea is that this helper_ prefix in the function names denote that are
for
17 matches
Mail list logo
