Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

Geert Uytterhoeven writes: Hello Geert, Thanks for your review! > Hi Javier, [...] >> - ssd130x->buffer = kcalloc(pitch, ssd130x->height, GFP_KERNEL); >> - if (!ssd130x->buffer) >> - return -ENOMEM; >> + ssd130x->buffer = devm_kcalloc(ssd130x->dev, pitc

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

Hi Javier, On Mon, Jul 17, 2023 at 12:37 PM Javier Martinez Canillas wrote: > Javier Martinez Canillas writes: > >> On Mon, Jul 17, 2023 at 10:48 AM Thomas Zimmermann > >> wrote: > >>> After some discussion on IRC, I'd suggest to allocate the buffer > >>> somewhere within probe. So it will alw

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

Hi Am 17.07.23 um 11:04 schrieb Geert Uytterhoeven: Hi Thomas, On Mon, Jul 17, 2023 at 10:48 AM Thomas Zimmermann wrote: Am 13.07.23 um 18:32 schrieb Javier Martinez Canillas: Geert reports that the following NULL pointer dereference happens for him after commit 49d7d581ceaf ("drm/ssd130x: D

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

Javier Martinez Canillas writes: > Geert Uytterhoeven writes: > > Hello Geert and Thomas, > >> Hi Thomas, >> >> On Mon, Jul 17, 2023 at 10:48 AM Thomas Zimmermann >> wrote: > > [...] > >>> >>> After some discussion on IRC, I'd suggest to allocate the buffer >>> somewhere within probe. So it wi

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

Geert Uytterhoeven writes: Hello Geert and Thomas, > Hi Thomas, > > On Mon, Jul 17, 2023 at 10:48 AM Thomas Zimmermann > wrote: [...] >> >> After some discussion on IRC, I'd suggest to allocate the buffer >> somewhere within probe. So it will always be there when the plane code runs. >> >> A

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

Hi Thomas, On Mon, Jul 17, 2023 at 10:48 AM Thomas Zimmermann wrote: > Am 13.07.23 um 18:32 schrieb Javier Martinez Canillas: > > Geert reports that the following NULL pointer dereference happens for him > > after commit 49d7d581ceaf ("drm/ssd130x: Don't allocate buffers on each > > plane update"

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

Thomas Zimmermann writes: Hello Thomas, > Hi > > Am 13.07.23 um 18:32 schrieb Javier Martinez Canillas: [...] >> >> +static const struct drm_mode_config_helper_funcs >> ssd130x_mode_config_helpers = { >> +.atomic_commit_tail = drm_atomic_helper_commit_tail_rpm, >> +}; >> + > > After so

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

Hi Am 13.07.23 um 18:32 schrieb Javier Martinez Canillas: Geert reports that the following NULL pointer dereference happens for him after commit 49d7d581ceaf ("drm/ssd130x: Don't allocate buffers on each plane update"): [drm] Initialized ssd130x 1.0.0 20220131 for 0-003c on minor 0 ss

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

Geert Uytterhoeven writes: Hello Geert, > Hi Javier, > > On Thu, Jul 13, 2023 at 6:32 PM Javier Martinez Canillas > wrote: >> Geert reports that the following NULL pointer dereference happens for him >> after commit 49d7d581ceaf ("drm/ssd130x: Don't allocate buffers on each >> plane update"): >

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

Hi Javier, On Thu, Jul 13, 2023 at 6:32 PM Javier Martinez Canillas wrote: > Geert reports that the following NULL pointer dereference happens for him > after commit 49d7d581ceaf ("drm/ssd130x: Don't allocate buffers on each > plane update"): > > [drm] Initialized ssd130x 1.0.0 20220131 for 0

[PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

Geert reports that the following NULL pointer dereference happens for him after commit 49d7d581ceaf ("drm/ssd130x: Don't allocate buffers on each plane update"): [drm] Initialized ssd130x 1.0.0 20220131 for 0-003c on minor 0 ssd130x-i2c 0-003c: [drm] surface width(128), height(32), bpp(1)