Re: Re: Re: Re: [PATCH] drm/sun4i: Fix blend registers corruption for DE2.0/DE3.0

2022-05-25 Thread Roman Stratiienko
ср, 25 мая 2022 г. в 18:14, Jernej Škrabec : > > Dne sreda, 25. maj 2022 ob 16:55:56 CEST je Roman Stratiienko napisal(a): > > вт, 24 мая 2022 г. в 22:14, Jernej Škrabec : > > > > > > Dne torek, 24. maj 2022 ob 19:14:35 CEST je Roman Stratiienko napisal(a): > > > > By the way, not related to this

Re: Re: Re: Re: [PATCH] drm/sun4i: Fix blend registers corruption for DE2.0/DE3.0

2022-05-25 Thread Jernej Škrabec
Dne sreda, 25. maj 2022 ob 16:55:56 CEST je Roman Stratiienko napisal(a): > вт, 24 мая 2022 г. в 22:14, Jernej Škrabec : > > > > Dne torek, 24. maj 2022 ob 19:14:35 CEST je Roman Stratiienko napisal(a): > > > By the way, not related to this issue: > > > > > > I cherry-picked > > >

Re: Re: Re: [PATCH] drm/sun4i: Fix blend registers corruption for DE2.0/DE3.0

2022-05-25 Thread Roman Stratiienko
вт, 24 мая 2022 г. в 22:14, Jernej Škrabec : > > Dne torek, 24. maj 2022 ob 19:14:35 CEST je Roman Stratiienko napisal(a): > > By the way, not related to this issue: > > > > I cherry-picked > > https://patchwork.kernel.org/project/dri-devel/patch/20220424162633.12369-9-sam...@sholland.org/ > > and

Re: Re: Re: [PATCH] drm/sun4i: Fix blend registers corruption for DE2.0/DE3.0

2022-05-25 Thread Roman Stratiienko
вт, 24 мая 2022 г. в 22:13, Jernej Škrabec : > > Don't top post, it's annoying and against rules. > > Dne torek, 24. maj 2022 ob 19:10:06 CEST je Roman Stratiienko napisal(a): > > Please draft a test for the zpos issue you're mentioning. > > > > It's very easy to do with kmsxx using python

Re: Re: Re: [PATCH] drm/sun4i: Fix blend registers corruption for DE2.0/DE3.0

2022-05-24 Thread Jernej Škrabec
Dne torek, 24. maj 2022 ob 19:14:35 CEST je Roman Stratiienko napisal(a): > By the way, not related to this issue: > > I cherry-picked > https://patchwork.kernel.org/project/dri-devel/patch/20220424162633.12369-9-sam...@sholland.org/ > and got a blank FB console on OPI3. > Can you check it

Re: Re: Re: [PATCH] drm/sun4i: Fix blend registers corruption for DE2.0/DE3.0

2022-05-24 Thread Jernej Škrabec
Don't top post, it's annoying and against rules. Dne torek, 24. maj 2022 ob 19:10:06 CEST je Roman Stratiienko napisal(a): > Please draft a test for the zpos issue you're mentioning. > > It's very easy to do with kmsxx using python wrapper. > > Or explain steps to reproduce here, I will write

Re: Re: [PATCH] drm/sun4i: Fix blend registers corruption for DE2.0/DE3.0

2022-05-24 Thread Roman Stratiienko
By the way, not related to this issue: I cherry-picked https://patchwork.kernel.org/project/dri-devel/patch/20220424162633.12369-9-sam...@sholland.org/ and got a blank FB console on OPI3. Can you check it please? Regards, Roman вт, 24 мая 2022 г. в 20:10, Roman Stratiienko : > > Please draft

Re: Re: [PATCH] drm/sun4i: Fix blend registers corruption for DE2.0/DE3.0

2022-05-24 Thread Roman Stratiienko
Please draft a test for the zpos issue you're mentioning. It's very easy to do with kmsxx using python wrapper. Or explain steps to reproduce here, I will write it by myself. Thanks. Regards Roman вт, 24 мая 2022 г. в 19:21, Jernej Škrabec : > > Dne torek, 24. maj 2022 ob 17:31:13 CEST je

Re: Re: [PATCH] drm/sun4i: Fix blend registers corruption for DE2.0/DE3.0

2022-05-24 Thread Jernej Škrabec
Dne torek, 24. maj 2022 ob 17:31:13 CEST je Roman Stratiienko napisal(a): > NAK for this. Further testing showed such an approach is not reliable > due to .atomic_update() callback called only in case planes have some > changes. Additionally, I think it would be better to fix underlaying zpos

Re: [PATCH] drm/sun4i: Fix blend registers corruption for DE2.0/DE3.0

2022-05-24 Thread Roman Stratiienko
NAK for this. Further testing showed such an approach is not reliable due to .atomic_update() callback called only in case planes have some changes. вт, 24 мая 2022 г. в 16:52, Roman Stratiienko : > > Corruption happens when plane zpos is updated > > Example scenario: > > Initial frame blender

[PATCH] drm/sun4i: Fix blend registers corruption for DE2.0/DE3.0

2022-05-24 Thread Roman Stratiienko
Corruption happens when plane zpos is updated Example scenario: Initial frame blender state: PLANE_ZPOS = {0, 1, 2, 3} BLD_ROUTE = {0, 1, 2, 0} BLD_EN = {1, 1, 1, 0} New frame commit (Only ZPOS has been changed): PLANE_ZPOS = {0->2, 1->0, 2->1, 3} Expected results after