Re: [PATCH] drm/sun4i: Use vi plane as primary

2019-09-20 Thread Roman Stratiienko
@Jernej Škrabec @Maxime Ripard Thanks for your time and valuable suggestions. Currently I would have to go away from mainline KMS to solve my (Android) issues, and I hope to get back when I find mainline-friendly solution for it. Having no primary layer or zero-buffer primary layer and 4

Re: [PATCH] drm/sun4i: Use vi plane as primary

2019-09-20 Thread Roman Stratiienko
[ Resending message in plain mode ] Hello guys, Actually, I believe this is True solution, and current one is wrong. Let me explain why. De2. 0 was designed to match Android hwcomposer hal requirements IMO. You can easily agree with this conclusion by comparing Composer HAL and De2. 0 hardware

[PATCH] drm/sun4i: Use vi plane as primary

2019-09-20 Thread roman . stratiienko
From: Roman Stratiienko DE2.0 blender does not take into the account alpha channel of vi layer. Thus makes overlaying of this layer totally opaque. Using vi layer as bottom solves this issue. Tested on Android. Signed-off-by: Roman Stratiienko --- drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 33

Re: [PATCH] drm/sun4i: Use vi plane as primary

2019-09-20 Thread Roman Stratiienko
Hello guys, Actually, I beleive this is True solution, and current one is wrong. Let me explain why. De2. 0 was designed to match Android hwcomposer hal requirements IMO. You can easily agree with this conclusion by comparing Composer HAL and De2. 0 hardware manuals. I faced at least 4 issues

Re: [PATCH] drm/sun4i: Use vi plane as primary

2019-09-20 Thread Maxime Ripard
Hi, On Thu, Sep 19, 2019 at 11:03:26PM +0300, Roman Stratiienko wrote: > Actually, I beleive this is True solution, and current one is wrong. Let > me explain why. > > De2. 0 was designed to match Android hwcomposer hal requirements IMO. > You can easily agree with this conclusion by comparing

Re: [PATCH] drm/sun4i: Use vi plane as primary

2019-09-20 Thread Maxime Ripard
On Thu, Sep 19, 2019 at 08:15:49PM +0200, Jernej Škrabec wrote: > Dne četrtek, 19. september 2019 ob 19:17:54 CEST je Maxime Ripard napisal(a): > > > > > > Tested on Android. > > > > > > Signed-off-by: Roman Stratiienko > > > > It sounds like a workaround more than an actual fix. > > > > If the

Re: [PATCH] drm/sun4i: Use vi plane as primary

2019-09-19 Thread Jernej Škrabec
Dne četrtek, 19. september 2019 ob 22:03:26 CEST je Roman Stratiienko napisal(a): > Hello guys, > > Actually, I beleive this is True solution, and current one is wrong. Let > me explain why. > > De2. 0 was designed to match Android hwcomposer hal requirements IMO. > You can easily agree with

Re: [PATCH] drm/sun4i: Use vi plane as primary

2019-09-19 Thread Jernej Škrabec
Dne četrtek, 19. september 2019 ob 19:17:54 CEST je Maxime Ripard napisal(a): > Hi, > > On Thu, Sep 19, 2019 at 03:37:03PM +0300, roman.stratiie...@globallogic.com wrote: > > From: Roman Stratiienko > > > > DE2.0 blender does not take into the account alpha channel of vi layer. > > Thus makes

Re: [PATCH] drm/sun4i: Use vi plane as primary

2019-09-19 Thread Maxime Ripard
Hi, On Thu, Sep 19, 2019 at 03:37:03PM +0300, roman.stratiie...@globallogic.com wrote: > From: Roman Stratiienko > > DE2.0 blender does not take into the account alpha channel of vi layer. > Thus makes overlaying of this layer totally opaque. > Using vi layer as bottom solves this issue. > >