Re: [PATCH] drm/sun4i: tcon: Unconditionally reset the TCON

2017-09-08 Thread Maxime Ripard
On Fri, Sep 08, 2017 at 02:49:52PM +0800, Chen-Yu Tsai wrote: > On Fri, Sep 8, 2017 at 2:42 PM, Maxime Ripard > wrote: > > Hi, > > > > On Fri, Sep 08, 2017 at 12:15:45PM +0800, Chen-Yu Tsai wrote: > >> When binding the TCON, we were checking the reset control

Re: [PATCH] drm/sun4i: tcon: Unconditionally reset the TCON

2017-09-08 Thread Chen-Yu Tsai
On Fri, Sep 8, 2017 at 2:42 PM, Maxime Ripard wrote: > Hi, > > On Fri, Sep 08, 2017 at 12:15:45PM +0800, Chen-Yu Tsai wrote: >> When binding the TCON, we were checking the reset control status and >> asserting reset if it wasn't in reset. The check failed to

Re: [PATCH] drm/sun4i: tcon: Unconditionally reset the TCON

2017-09-08 Thread Maxime Ripard
Hi, On Fri, Sep 08, 2017 at 12:15:45PM +0800, Chen-Yu Tsai wrote: > When binding the TCON, we were checking the reset control status and > asserting reset if it wasn't in reset. The check failed to account for > the reset control API returning error codes if the status callback was > not

[PATCH] drm/sun4i: tcon: Unconditionally reset the TCON

2017-09-07 Thread Chen-Yu Tsai
When binding the TCON, we were checking the reset control status and asserting reset if it wasn't in reset. The check failed to account for the reset control API returning error codes if the status callback was not implemented. Since we want the TCON to be reset in all cases, and re-asserting the