Re: [PATCH] drm/tegra: submit: No need for Null pointer check before kfree

2023-01-22 Thread Deepak R Varma
On Mon, Jan 02, 2023 at 11:50:36PM +0530, Deepak R Varma wrote: > On Fri, Dec 30, 2022 at 12:03:25PM +0200, Mikko Perttunen wrote: > > On 12/30/22 12:01, Mikko Perttunen wrote: > > > On 12/30/22 11:15, Stanislaw Gruszka wrote: > > > > On Wed, Dec 28, 2022 at 03:17:59PM +0200, Mikko Perttunen wrote:

Re: [PATCH] drm/tegra: submit: No need for Null pointer check before kfree

2023-01-02 Thread Deepak R Varma
On Fri, Dec 30, 2022 at 12:03:25PM +0200, Mikko Perttunen wrote: > On 12/30/22 12:01, Mikko Perttunen wrote: > > On 12/30/22 11:15, Stanislaw Gruszka wrote: > > > On Wed, Dec 28, 2022 at 03:17:59PM +0200, Mikko Perttunen wrote: > > > > On 12/28/22 15:08, Deepak R Varma wrote: > > > > > On Wed, Dec

Re: [PATCH] drm/tegra: submit: No need for Null pointer check before kfree

2022-12-30 Thread Stanislaw Gruszka
On Fri, Dec 30, 2022 at 12:01:23PM +0200, Mikko Perttunen wrote: > On 12/30/22 11:15, Stanislaw Gruszka wrote: > > On Wed, Dec 28, 2022 at 03:17:59PM +0200, Mikko Perttunen wrote: > > > On 12/28/22 15:08, Deepak R Varma wrote: > > > > On Wed, Dec 28, 2022 at 02:28:54PM +0200, Mikko Perttunen wrote:

Re: [PATCH] drm/tegra: submit: No need for Null pointer check before kfree

2022-12-30 Thread Mikko Perttunen
On 12/30/22 12:01, Mikko Perttunen wrote: On 12/30/22 11:15, Stanislaw Gruszka wrote: On Wed, Dec 28, 2022 at 03:17:59PM +0200, Mikko Perttunen wrote: On 12/28/22 15:08, Deepak R Varma wrote: On Wed, Dec 28, 2022 at 02:28:54PM +0200, Mikko Perttunen wrote: On 12/27/22 19:14, Deepak R Varma wr

Re: [PATCH] drm/tegra: submit: No need for Null pointer check before kfree

2022-12-30 Thread Mikko Perttunen
On 12/30/22 11:15, Stanislaw Gruszka wrote: On Wed, Dec 28, 2022 at 03:17:59PM +0200, Mikko Perttunen wrote: On 12/28/22 15:08, Deepak R Varma wrote: On Wed, Dec 28, 2022 at 02:28:54PM +0200, Mikko Perttunen wrote: On 12/27/22 19:14, Deepak R Varma wrote: kfree() & vfree() internally perform

Re: [PATCH] drm/tegra: submit: No need for Null pointer check before kfree

2022-12-30 Thread Stanislaw Gruszka
On Wed, Dec 28, 2022 at 03:17:59PM +0200, Mikko Perttunen wrote: > On 12/28/22 15:08, Deepak R Varma wrote: > > On Wed, Dec 28, 2022 at 02:28:54PM +0200, Mikko Perttunen wrote: > > > On 12/27/22 19:14, Deepak R Varma wrote: > > > > kfree() & vfree() internally perform NULL check on the pointer hand

Re: [PATCH] drm/tegra: submit: No need for Null pointer check before kfree

2022-12-28 Thread Deepak R Varma
On Wed, Dec 28, 2022 at 03:48:05PM +0200, Mikko Perttunen wrote: > On 12/28/22 15:34, Deepak R Varma wrote: > > On Wed, Dec 28, 2022 at 03:17:59PM +0200, Mikko Perttunen wrote: > > > On 12/28/22 15:08, Deepak R Varma wrote: > > > > > > Hi, > > > > > > it gets rid of visual hints on code paths indic

Re: [PATCH] drm/tegra: submit: No need for Null pointer check before kfree

2022-12-28 Thread Mikko Perttunen
On 12/28/22 15:34, Deepak R Varma wrote: On Wed, Dec 28, 2022 at 03:17:59PM +0200, Mikko Perttunen wrote: On 12/28/22 15:08, Deepak R Varma wrote: On Wed, Dec 28, 2022 at 02:28:54PM +0200, Mikko Perttunen wrote: On 12/27/22 19:14, Deepak R Varma wrote: kfree() & vfree() internally perform NUL

Re: [PATCH] drm/tegra: submit: No need for Null pointer check before kfree

2022-12-28 Thread Deepak R Varma
On Wed, Dec 28, 2022 at 03:17:59PM +0200, Mikko Perttunen wrote: > On 12/28/22 15:08, Deepak R Varma wrote: > > On Wed, Dec 28, 2022 at 02:28:54PM +0200, Mikko Perttunen wrote: > > > On 12/27/22 19:14, Deepak R Varma wrote: > > > > kfree() & vfree() internally perform NULL check on the pointer hand

Re: [PATCH] drm/tegra: submit: No need for Null pointer check before kfree

2022-12-28 Thread Mikko Perttunen
On 12/28/22 15:08, Deepak R Varma wrote: On Wed, Dec 28, 2022 at 02:28:54PM +0200, Mikko Perttunen wrote: On 12/27/22 19:14, Deepak R Varma wrote: kfree() & vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pr

Re: [PATCH] drm/tegra: submit: No need for Null pointer check before kfree

2022-12-28 Thread Deepak R Varma
On Wed, Dec 28, 2022 at 02:28:54PM +0200, Mikko Perttunen wrote: > On 12/27/22 19:14, Deepak R Varma wrote: > > kfree() & vfree() internally perform NULL check on the pointer handed > > to it and take no action if it indeed is NULL. Hence there is no need > > for a pre-check of the memory pointer b

Re: [PATCH] drm/tegra: submit: No need for Null pointer check before kfree

2022-12-28 Thread Mikko Perttunen
On 12/27/22 19:14, Deepak R Varma wrote: kfree() & vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree(). Issue reported by ifnullfree.cocci Cocc

[PATCH] drm/tegra: submit: No need for Null pointer check before kfree

2022-12-27 Thread Deepak R Varma
kfree() & vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree(). Issue reported by ifnullfree.cocci Coccinelle semantic patch script. Signed-off-b