Re: [PATCH] drm/tilcdc: Set framebuffer DMA address to HW only if CRTC is enabled

2017-03-13 Thread Tomi Valkeinen
On 11/03/17 19:25, Jyri Sarha wrote: > Touching HW while clocks are off is a serious error and for instance > breaks suspend functionality. After this patch tilcdc_crtc_update_fb() > always updates the primary plane's framebuffer pointer, increases fb's > reference count and stores vblank event. ti

Re: [PATCH] drm/tilcdc: Set framebuffer DMA address to HW only if CRTC is enabled

2017-03-13 Thread Jyri Sarha
On 03/11/17 19:25, Jyri Sarha wrote: > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > index f80bf93..bd92c89 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > @@ -1,4 +1,4 @@ > -/* > +* > * Copyright (

Re: [PATCH] drm/tilcdc: Set framebuffer DMA address to HW only if CRTC is enabled

2017-03-12 Thread kbuild test robot
Hi Jyri, [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.11-rc2 next-20170310] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jyri-Sarha/drm-tilcdc-Set-framebuffer-DMA-addre

Re: [PATCH] drm/tilcdc: Set framebuffer DMA address to HW only if CRTC is enabled

2017-03-12 Thread kbuild test robot
Hi Jyri, [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.11-rc1 next-20170310] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jyri-Sarha/drm-tilcdc-Set-framebuffer-DMA-addre

[PATCH] drm/tilcdc: Set framebuffer DMA address to HW only if CRTC is enabled

2017-03-11 Thread Jyri Sarha
Touching HW while clocks are off is a serious error and for instance breaks suspend functionality. After this patch tilcdc_crtc_update_fb() always updates the primary plane's framebuffer pointer, increases fb's reference count and stores vblank event. tilcdc_crtc_update_fb() only writes the fb's DM

[PATCH] drm/tilcdc: Set framebuffer DMA address to HW only if CRTC is enabled

2017-03-02 Thread Jyri Sarha
Touching HW while clocks are of is a serious error and for instance breaks suspend functionality. After the patch tilcdc_crtc_update_fb() always updates the primary planes framebuffer pointer, increases fb's reference count and stores vblank event. The framebuffer's DMA address is written to HW onl