[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/20/2011 04:13 PM, Jerome Glisse wrote: > On Sun, Nov 20, 2011 at 4:30 AM, Thomas Hellstrom > wrote: > >> On 11/19/2011 11:54 PM, Jerome Glisse wrote: >> >> As mentioned previously, and in the discussion with Ben, the page tables >> would not need to be rebuilt on each CS. They would be

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/20/2011 04:13 PM, Jerome Glisse wrote: On Sun, Nov 20, 2011 at 4:30 AM, Thomas Hellstromthellst...@vmware.com wrote: On 11/19/2011 11:54 PM, Jerome Glisse wrote: As mentioned previously, and in the discussion with Ben, the page tables would not need to be rebuilt on each CS. They

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/19/2011 11:54 PM, Jerome Glisse wrote: > >> As mentioned previously, and in the discussion with Ben, the page tables >> would not need to be rebuilt on each CS. They would be rebuilt only on the >> first CS following a move_notify that caused a page table invalidation. >> >> move_notify: >>

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Sun, Nov 20, 2011 at 4:30 AM, Thomas Hellstrom wrote: > On 11/19/2011 11:54 PM, Jerome Glisse wrote: > > As mentioned previously, and in the discussion with Ben, the page tables > would not need to be rebuilt on each CS. They would be rebuilt only on the > first CS following a move_notify

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Sat, 2011-11-19 at 11:07 +0100, Thomas Hellstrom wrote: > On 11/19/2011 01:26 AM, Ben Skeggs wrote: > > On Fri, 2011-11-18 at 23:48 +0100, Thomas Hellstrom wrote: > > > >> On 11/18/2011 06:26 PM, Ben Skeggs wrote: > >> > >>> On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: >

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/19/2011 11:54 PM, Jerome Glisse wrote: As mentioned previously, and in the discussion with Ben, the page tables would not need to be rebuilt on each CS. They would be rebuilt only on the first CS following a move_notify that caused a page table invalidation. move_notify: if

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Sun, Nov 20, 2011 at 4:30 AM, Thomas Hellstrom thellst...@vmware.com wrote: On 11/19/2011 11:54 PM, Jerome Glisse wrote: As mentioned previously, and in the discussion with Ben, the page tables would not need to be rebuilt on each CS. They would be rebuilt only on the first CS following a

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/19/2011 10:22 PM, Jerome Glisse wrote: > On Sat, Nov 19, 2011 at 4:01 PM, Thomas Hellstrom > wrote: > >> On 11/19/2011 09:37 PM, Jerome Glisse wrote: >> >>> On Sat, Nov 19, 2011 at 2:46 PM, Thomas Hellstrom >>> wrote: >>> >>> On 11/19/2011 07:11 PM, Jerome Glisse

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/19/2011 09:37 PM, Jerome Glisse wrote: > On Sat, Nov 19, 2011 at 2:46 PM, Thomas Hellstrom > wrote: > >> On 11/19/2011 07:11 PM, Jerome Glisse wrote: >> >> On Sat, Nov 19, 2011 at 12:00 PM, Thomas Hellstrom >> wrote: >> >> >> On 11/19/2011 03:53 PM, Ben Skeggs wrote: >> >> >> On Sat,

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/19/2011 07:11 PM, Jerome Glisse wrote: > On Sat, Nov 19, 2011 at 12:00 PM, Thomas Hellstrom > wrote: > >> On 11/19/2011 03:53 PM, Ben Skeggs wrote: >> >>> On Sat, 2011-11-19 at 11:07 +0100, Thomas Hellstrom wrote: >>> >>> On 11/19/2011 01:26 AM, Ben Skeggs wrote:

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/19/2011 03:53 PM, Ben Skeggs wrote: > On Sat, 2011-11-19 at 11:07 +0100, Thomas Hellstrom wrote: > >> On 11/19/2011 01:26 AM, Ben Skeggs wrote: >> >>> On Fri, 2011-11-18 at 23:48 +0100, Thomas Hellstrom wrote: >>> >>> On 11/18/2011 06:26 PM, Ben Skeggs wrote:

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Sat, Nov 19, 2011 at 5:37 PM, Thomas Hellstrom wrote: > On 11/19/2011 10:22 PM, Jerome Glisse wrote: >> >> On Sat, Nov 19, 2011 at 4:01 PM, Thomas Hellstrom >> ?wrote: >> >>> >>> On 11/19/2011 09:37 PM, Jerome Glisse wrote: >>> On Sat, Nov 19, 2011 at 2:46 PM, Thomas Hellstrom

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Sat, Nov 19, 2011 at 4:01 PM, Thomas Hellstrom wrote: > On 11/19/2011 09:37 PM, Jerome Glisse wrote: >> >> On Sat, Nov 19, 2011 at 2:46 PM, Thomas Hellstrom >> ?wrote: >> >>> >>> On 11/19/2011 07:11 PM, Jerome Glisse wrote: >>> >>> On Sat, Nov 19, 2011 at 12:00 PM, Thomas Hellstrom >>>

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Sat, Nov 19, 2011 at 2:46 PM, Thomas Hellstrom wrote: > On 11/19/2011 07:11 PM, Jerome Glisse wrote: > > On Sat, Nov 19, 2011 at 12:00 PM, Thomas Hellstrom > wrote: > > > On 11/19/2011 03:53 PM, Ben Skeggs wrote: > > > On Sat, 2011-11-19 at 11:07 +0100, Thomas Hellstrom wrote: > > > > On

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Sat, Nov 19, 2011 at 12:00 PM, Thomas Hellstrom wrote: > On 11/19/2011 03:53 PM, Ben Skeggs wrote: >> >> On Sat, 2011-11-19 at 11:07 +0100, Thomas Hellstrom wrote: >> >>> >>> On 11/19/2011 01:26 AM, Ben Skeggs wrote: >>> On Fri, 2011-11-18 at 23:48 +0100, Thomas Hellstrom wrote:

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/19/2011 01:26 AM, Ben Skeggs wrote: > On Fri, 2011-11-18 at 23:48 +0100, Thomas Hellstrom wrote: > >> On 11/18/2011 06:26 PM, Ben Skeggs wrote: >> >>> On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: >>> >>> On 11/18/2011 02:15 PM, Ben Skeggs wrote:

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Fri, 2011-11-18 at 23:48 +0100, Thomas Hellstrom wrote: > On 11/18/2011 06:26 PM, Ben Skeggs wrote: > > On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: > > > >> On 11/18/2011 02:15 PM, Ben Skeggs wrote: > >> > >>> On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: >

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: > On 11/18/2011 02:15 PM, Ben Skeggs wrote: > > On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: > > > >> Jerome, > >> > >> I don't like this change for the following reasons > >> > > -snip- > > > > > >>> One can

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/19/2011 01:26 AM, Ben Skeggs wrote: On Fri, 2011-11-18 at 23:48 +0100, Thomas Hellstrom wrote: On 11/18/2011 06:26 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: On 11/18/2011 02:15 PM, Ben Skeggs wrote: On Fri, 2011-11-18

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Sat, 2011-11-19 at 11:07 +0100, Thomas Hellstrom wrote: On 11/19/2011 01:26 AM, Ben Skeggs wrote: On Fri, 2011-11-18 at 23:48 +0100, Thomas Hellstrom wrote: On 11/18/2011 06:26 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: On

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/19/2011 03:53 PM, Ben Skeggs wrote: On Sat, 2011-11-19 at 11:07 +0100, Thomas Hellstrom wrote: On 11/19/2011 01:26 AM, Ben Skeggs wrote: On Fri, 2011-11-18 at 23:48 +0100, Thomas Hellstrom wrote: On 11/18/2011 06:26 PM, Ben Skeggs wrote: On Fri, 2011-11-18

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Sat, Nov 19, 2011 at 12:00 PM, Thomas Hellstrom thellst...@vmware.com wrote: On 11/19/2011 03:53 PM, Ben Skeggs wrote: On Sat, 2011-11-19 at 11:07 +0100, Thomas Hellstrom wrote: On 11/19/2011 01:26 AM, Ben Skeggs wrote: On Fri, 2011-11-18 at 23:48 +0100, Thomas Hellstrom wrote: On

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/19/2011 07:11 PM, Jerome Glisse wrote: On Sat, Nov 19, 2011 at 12:00 PM, Thomas Hellstrom thellst...@vmware.com wrote: On 11/19/2011 03:53 PM, Ben Skeggs wrote: On Sat, 2011-11-19 at 11:07 +0100, Thomas Hellstrom wrote: On 11/19/2011 01:26 AM, Ben Skeggs wrote:

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Sat, Nov 19, 2011 at 2:46 PM, Thomas Hellstrom thellst...@vmware.com wrote: On 11/19/2011 07:11 PM, Jerome Glisse wrote: On Sat, Nov 19, 2011 at 12:00 PM, Thomas Hellstrom thellst...@vmware.com wrote: On 11/19/2011 03:53 PM, Ben Skeggs wrote: On Sat, 2011-11-19 at 11:07 +0100, Thomas

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/19/2011 09:37 PM, Jerome Glisse wrote: On Sat, Nov 19, 2011 at 2:46 PM, Thomas Hellstromthellst...@vmware.com wrote: On 11/19/2011 07:11 PM, Jerome Glisse wrote: On Sat, Nov 19, 2011 at 12:00 PM, Thomas Hellstrom thellst...@vmware.com wrote: On 11/19/2011 03:53 PM, Ben Skeggs

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Sat, Nov 19, 2011 at 4:01 PM, Thomas Hellstrom thellst...@vmware.com wrote: On 11/19/2011 09:37 PM, Jerome Glisse wrote: On Sat, Nov 19, 2011 at 2:46 PM, Thomas Hellstromthellst...@vmware.com  wrote: On 11/19/2011 07:11 PM, Jerome Glisse wrote: On Sat, Nov 19, 2011 at 12:00 PM, Thomas

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Sat, Nov 19, 2011 at 5:37 PM, Thomas Hellstrom thellst...@vmware.com wrote: On 11/19/2011 10:22 PM, Jerome Glisse wrote: On Sat, Nov 19, 2011 at 4:01 PM, Thomas Hellstromthellst...@vmware.com  wrote: On 11/19/2011 09:37 PM, Jerome Glisse wrote: On Sat, Nov 19, 2011 at 2:46 PM, Thomas

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/18/2011 06:26 PM, Ben Skeggs wrote: > On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: > >> On 11/18/2011 02:15 PM, Ben Skeggs wrote: >> >>> On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: >>> >>> Jerome, I don't like this change for the

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: > Jerome, > > I don't like this change for the following reasons -snip- > > > > One can take advantage of move notify callback but, there are > > corner case where bind/unbind might be call without move notify > > being call (in error

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Fri, Nov 18, 2011 at 6:25 PM, Jerome Glisse wrote: > On Fri, Nov 18, 2011 at 06:14:02PM -0500, Jerome Glisse wrote: >> On Fri, Nov 18, 2011 at 11:48:58PM +0100, Thomas Hellstrom wrote: >> > On 11/18/2011 06:26 PM, Ben Skeggs wrote: >> > >On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Fri, Nov 18, 2011 at 06:14:02PM -0500, Jerome Glisse wrote: > On Fri, Nov 18, 2011 at 11:48:58PM +0100, Thomas Hellstrom wrote: > > On 11/18/2011 06:26 PM, Ben Skeggs wrote: > > >On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: > > >>On 11/18/2011 02:15 PM, Ben Skeggs wrote: > > >>>On

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Fri, Nov 18, 2011 at 11:48:58PM +0100, Thomas Hellstrom wrote: > On 11/18/2011 06:26 PM, Ben Skeggs wrote: > >On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: > >>On 11/18/2011 02:15 PM, Ben Skeggs wrote: > >>>On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: > >>> >

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/18/2011 03:56 PM, Jerome Glisse wrote: > On Fri, Nov 18, 2011 at 03:30:03PM +0100, Thomas Hellstrom wrote: > >> On 11/18/2011 02:15 PM, Ben Skeggs wrote: >> >>> On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: >>> Jerome, I don't like this change

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/18/2011 02:15 PM, Ben Skeggs wrote: > On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: > >> Jerome, >> >> I don't like this change for the following reasons >> > -snip- > > >>> One can take advantage of move notify callback but, there are >>> corner case where

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Fri, Nov 18, 2011 at 04:06:05PM +0100, Thomas Hellstrom wrote: > On 11/18/2011 03:56 PM, Jerome Glisse wrote: > >On Fri, Nov 18, 2011 at 03:30:03PM +0100, Thomas Hellstrom wrote: > >>On 11/18/2011 02:15 PM, Ben Skeggs wrote: > >>>On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: >

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Fri, Nov 18, 2011 at 03:30:03PM +0100, Thomas Hellstrom wrote: > On 11/18/2011 02:15 PM, Ben Skeggs wrote: > >On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: > >>Jerome, > >> > >>I don't like this change for the following reasons > >-snip- > > > >>>One can take advantage of move

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

Jerome, I don't like this change for the following reasons 1) This is really a layer violation. It's like passing a state tracker object down to the pipe driver i Gallium, so that eventually the winsys can access it. 2) TTM, as you say, doesn't really care about GPU virtual maps. It cares

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

Jerome, I don't like this change for the following reasons 1) This is really a layer violation. It's like passing a state tracker object down to the pipe driver i Gallium, so that eventually the winsys can access it. 2) TTM, as you say, doesn't really care about GPU virtual maps. It cares

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/18/2011 02:15 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: Jerome, I don't like this change for the following reasons -snip- One can take advantage of move notify callback but, there are corner case where bind/unbind might be call

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Fri, Nov 18, 2011 at 03:30:03PM +0100, Thomas Hellstrom wrote: On 11/18/2011 02:15 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: Jerome, I don't like this change for the following reasons -snip- One can take advantage of move notify callback but,

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Fri, Nov 18, 2011 at 04:06:05PM +0100, Thomas Hellstrom wrote: On 11/18/2011 03:56 PM, Jerome Glisse wrote: On Fri, Nov 18, 2011 at 03:30:03PM +0100, Thomas Hellstrom wrote: On 11/18/2011 02:15 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: Jerome, I

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: On 11/18/2011 02:15 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: Jerome, I don't like this change for the following reasons -snip- One can take advantage of move notify

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On 11/18/2011 06:26 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: On 11/18/2011 02:15 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: Jerome, I don't like this change for the following reasons

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Fri, Nov 18, 2011 at 11:48:58PM +0100, Thomas Hellstrom wrote: On 11/18/2011 06:26 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: On 11/18/2011 02:15 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote: Jerome, I don't like

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Fri, Nov 18, 2011 at 06:14:02PM -0500, Jerome Glisse wrote: On Fri, Nov 18, 2011 at 11:48:58PM +0100, Thomas Hellstrom wrote: On 11/18/2011 06:26 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: On 11/18/2011 02:15 PM, Ben Skeggs wrote: On Fri,

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Fri, Nov 18, 2011 at 6:25 PM, Jerome Glisse j.gli...@gmail.com wrote: On Fri, Nov 18, 2011 at 06:14:02PM -0500, Jerome Glisse wrote: On Fri, Nov 18, 2011 at 11:48:58PM +0100, Thomas Hellstrom wrote: On 11/18/2011 06:26 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 15:30 +0100, Thomas

Re: [PATCH] drm/ttm: pass buffer object for bind/unbind callback

On Fri, 2011-11-18 at 23:48 +0100, Thomas Hellstrom wrote: On 11/18/2011 06:26 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 15:30 +0100, Thomas Hellstrom wrote: On 11/18/2011 02:15 PM, Ben Skeggs wrote: On Fri, 2011-11-18 at 08:57 +0100, Thomas Hellstrom wrote:

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

From: Jerome Glisse ttm_tt is always associated with a buffer object, pass it in bind/unbind callback to make life easier for driver. Main objective is for driver supporting virtual address space. For such driver each buffer object can be several virtual address space but

[PATCH] drm/ttm: pass buffer object for bind/unbind callback

From: Jerome Glisse jgli...@redhat.com ttm_tt is always associated with a buffer object, pass it in bind/unbind callback to make life easier for driver. Main objective is for driver supporting virtual address space. For such driver each buffer object can be several virtual address space but ttm