Re: [PATCH] drm/usb: select USB_SUPPORT in Kconfig

2012-08-18 Thread Sachin Kamat
Hi Dave, What is your opinion about this patch? On 15 August 2012 01:27, Sascha Hauer s.ha...@pengutronix.de wrote: On Tue, Aug 14, 2012 at 05:12:22PM +0530, Sachin Kamat wrote: In general what you suggested seems to be the right thing to do. However in this particular case, making this

[PATCH] drm/usb: select USB_SUPPORT in Kconfig

2012-08-17 Thread Sachin Kamat
Hi Dave, What is your opinion about this patch? On 15 August 2012 01:27, Sascha Hauer wrote: > On Tue, Aug 14, 2012 at 05:12:22PM +0530, Sachin Kamat wrote: >> >> In general what you suggested seems to be the right thing to do. >> However in this particular case, making this "depends on"

[PATCH] drm/usb: select USB_SUPPORT in Kconfig

2012-08-14 Thread Sascha Hauer
On Tue, Aug 14, 2012 at 05:12:22PM +0530, Sachin Kamat wrote: > > In general what you suggested seems to be the right thing to do. > However in this particular case, making this "depends on" creates > recursive dependencies > and probably that is the reason Dave Airlie decided to make it "select

[PATCH] drm/usb: select USB_SUPPORT in Kconfig

2012-08-14 Thread Sachin Kamat
On 10 August 2012 19:35, Sascha Hauer wrote: > On Fri, Aug 10, 2012 at 11:00:25AM +0530, Sachin Kamat wrote: >> DRM_USB selects USB. However, USB depends on USB_SUPPORT and >> USB_ARCH_HAS_HCD. >> Thus, selecting USB_SUPPORT in Kconfig avoids the following warning >> (detected when DisplayLink

Re: [PATCH] drm/usb: select USB_SUPPORT in Kconfig

2012-08-14 Thread Sascha Hauer
On Tue, Aug 14, 2012 at 05:12:22PM +0530, Sachin Kamat wrote: In general what you suggested seems to be the right thing to do. However in this particular case, making this depends on creates recursive dependencies and probably that is the reason Dave Airlie decided to make it select USB

[PATCH] drm/usb: select USB_SUPPORT in Kconfig

2012-08-10 Thread Sascha Hauer
On Fri, Aug 10, 2012 at 11:00:25AM +0530, Sachin Kamat wrote: > DRM_USB selects USB. However, USB depends on USB_SUPPORT and USB_ARCH_HAS_HCD. > Thus, selecting USB_SUPPORT in Kconfig avoids the following warning > (detected when DisplayLink was selected using exynos4_defconfig): > > warning:

[PATCH] drm/usb: select USB_SUPPORT in Kconfig

2012-08-10 Thread Sachin Kamat
DRM_USB selects USB. However, USB depends on USB_SUPPORT and USB_ARCH_HAS_HCD. Thus, selecting USB_SUPPORT in Kconfig avoids the following warning (detected when DisplayLink was selected using exynos4_defconfig): warning: (MOUSE_APPLETOUCH && MOUSE_BCM5974 && MOUSE_SYNAPTICS_USB && JOYSTICK_XPAD

[PATCH] drm/usb: select USB_SUPPORT in Kconfig

2012-08-10 Thread Sachin Kamat
DRM_USB selects USB. However, USB depends on USB_SUPPORT and USB_ARCH_HAS_HCD. Thus, selecting USB_SUPPORT in Kconfig avoids the following warning (detected when DisplayLink was selected using exynos4_defconfig): warning: (MOUSE_APPLETOUCH MOUSE_BCM5974 MOUSE_SYNAPTICS_USB JOYSTICK_XPAD