Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-09 Thread Michel Dänzer
On 1/5/23 16:16, Yi Xie wrote: > On Thu, Jan 5, 2023 at 11:16 PM Daniel Vetter wrote: >> >> Ah ok. For next time around, copy a link to the comment you want, e.g. >> >> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5830#note_582477 >> >> The 3 dots menu on each comments has an option

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-07 Thread 吴涛@Eng
On Sat, Jan 7, 2023 at 2:45 AM Simon Ser wrote: > > On Friday, January 6th, 2023 at 23:28, Tao Wu wrote: > > > On Fri, Jan 6, 2023 at 1:54 AM Daniel Vetter dan...@ffwll.ch wrote: > > > > > On Thu, Jan 05, 2023 at 01:40:28PM -0800, Tao Wu(吴涛@Eng) wrote: > > > > > > > Hi Daniel, > > > > > > > >

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-07 Thread Simon Ser
On Friday, January 6th, 2023 at 23:28, Tao Wu wrote: > On Fri, Jan 6, 2023 at 1:54 AM Daniel Vetter dan...@ffwll.ch wrote: > > > On Thu, Jan 05, 2023 at 01:40:28PM -0800, Tao Wu(吴涛@Eng) wrote: > > > > > Hi Daniel, > > > > > > May I know what's the requirement for adding render node support to

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-06 Thread 吴涛@Eng
On Fri, Jan 6, 2023 at 1:54 AM Daniel Vetter wrote: > > On Thu, Jan 05, 2023 at 01:40:28PM -0800, Tao Wu(吴涛@Eng) wrote: > > Hi Daniel, > > > > May I know what's the requirement for adding render node support to a > > "gpu"? Why we just export render node for every drm devices? > > I read

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-06 Thread Daniel Vetter
On Fri, Jan 06, 2023 at 07:02:22PM +0900, Yi Xie wrote: > I have figured out the problem with importing buffers across vgem/vkms. > > It's intentionally blocked by kernel here: > https://github.com/torvalds/linux/blob/a140a6a2d5ec0329ad05cd3532a91ad0ce58dceb/drivers/gpu/drm/drm_gem.c#L307 Uh

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-06 Thread Yi Xie
I have figured out the problem with importing buffers across vgem/vkms. It's intentionally blocked by kernel here: https://github.com/torvalds/linux/blob/a140a6a2d5ec0329ad05cd3532a91ad0ce58dceb/drivers/gpu/drm/drm_gem.c#L307 >From the original patch

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-06 Thread Daniel Vetter
On Thu, Jan 05, 2023 at 01:40:28PM -0800, Tao Wu(吴涛@Eng) wrote: > Hi Daniel, > > May I know what's the requirement for adding render node support to a > "gpu"? Why we just export render node for every drm devices? > I read document here >

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread 吴涛@Eng
Hi Daniel, May I know what's the requirement for adding render node support to a "gpu"? Why we just export render node for every drm devices? I read document here https://www.kernel.org/doc/html/v4.8/gpu/drm-uapi.html#render-nodes and it seems render node allow multiple unprivileged clients to

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Daniel Vetter
On Fri, Jan 06, 2023 at 12:16:07AM +0900, Yi Xie wrote: > On Thu, Jan 5, 2023 at 11:16 PM Daniel Vetter wrote: > > > > On Thu, Jan 05, 2023 at 11:10:23PM +0900, Yi Xie wrote: > > > On Thu, Jan 5, 2023 at 10:48 PM Daniel Vetter wrote: > > > > > > > > On Thu, Jan 05, 2023 at 09:52:26PM +0900, Yi

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Yi Xie
On Thu, Jan 5, 2023 at 11:16 PM Daniel Vetter wrote: > > On Thu, Jan 05, 2023 at 11:10:23PM +0900, Yi Xie wrote: > > On Thu, Jan 5, 2023 at 10:48 PM Daniel Vetter wrote: > > > > > > On Thu, Jan 05, 2023 at 09:52:26PM +0900, Yi Xie wrote: > > > > > This doesn't sound like a good idea to me.

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Daniel Vetter
On Thu, Jan 05, 2023 at 11:10:23PM +0900, Yi Xie wrote: > On Thu, Jan 5, 2023 at 10:48 PM Daniel Vetter wrote: > > > > On Thu, Jan 05, 2023 at 09:52:26PM +0900, Yi Xie wrote: > > > > This doesn't sound like a good idea to me. Devices without render > > > > capabilities should not fake it. > > > >

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Yi Xie
On Thu, Jan 5, 2023 at 10:48 PM Daniel Vetter wrote: > > On Thu, Jan 05, 2023 at 09:52:26PM +0900, Yi Xie wrote: > > > This doesn't sound like a good idea to me. Devices without render > > > capabilities should not fake it. > > > > > > User-space (e.g. wlroots) relies on "no render node" to

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Daniel Vetter
On Thu, Jan 05, 2023 at 09:52:26PM +0900, Yi Xie wrote: > > This doesn't sound like a good idea to me. Devices without render > > capabilities should not fake it. > > > > User-space (e.g. wlroots) relies on "no render node" to enable > > software rendering (Pixman instead of GL). > > We have

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Yi Xie
> This doesn't sound like a good idea to me. Devices without render > capabilities should not fake it. > > User-space (e.g. wlroots) relies on "no render node" to enable > software rendering (Pixman instead of GL). We have virtgpu driver that exports a render node even when virgl is not

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Daniel Vetter
On Thu, Jan 05, 2023 at 02:23:25PM +0900, Yi Xie wrote: > Some libraries including Mesa and virglrenderer require a render node to > fully function. By adding a render node to vkms those libraries will > work properly, supporting use cases like running crosvm with virgl GPU > support via llvmpipe

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Simon Ser
On Thursday, January 5th, 2023 at 06:23, Yi Xie wrote: > Some libraries including Mesa and virglrenderer require a render node to > fully function. By adding a render node to vkms those libraries will > work properly, supporting use cases like running crosvm with virgl GPU > support via llvmpipe

[PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-04 Thread Yi Xie
Some libraries including Mesa and virglrenderer require a render node to fully function. By adding a render node to vkms those libraries will work properly, supporting use cases like running crosvm with virgl GPU support via llvmpipe on a headless virtual machine. Signed-off-by: Yi Xie ---