Re: [PATCH] drm/vmwgfx/vmwgfx_drv: Fix an error path in vmw_setup_pci_resources()

On Mon, Jan 25, 2021 at 07:13:43PM +, Zack Rusin wrote: > > > > On Jan 25, 2021, at 03:45, Dan Carpenter wrote: > > > > The devm_memremap() function never returns NULL, it returns error > > pointers so the test needs to be fixed. Also we need to call > > pci_release_regions() to avoid a

Re: [PATCH] drm/vmwgfx/vmwgfx_drv: Fix an error path in vmw_setup_pci_resources()

> On Jan 25, 2021, at 03:45, Dan Carpenter wrote: > > The devm_memremap() function never returns NULL, it returns error > pointers so the test needs to be fixed. Also we need to call > pci_release_regions() to avoid a memory leak. > > Fixes: be4f77ac6884 ("drm/vmwgfx: Cleanup fifo mmio

[PATCH] drm/vmwgfx/vmwgfx_drv: Fix an error path in vmw_setup_pci_resources()

The devm_memremap() function never returns NULL, it returns error pointers so the test needs to be fixed. Also we need to call pci_release_regions() to avoid a memory leak. Fixes: be4f77ac6884 ("drm/vmwgfx: Cleanup fifo mmio handling") Signed-off-by: Dan Carpenter ---