Re: [Linux-graphics-maintainer] [PATCH] drm/vmwgfx: Fix potential Spectre v1

2018-08-24 Thread Gustavo A. R. Silva
Hi all, On 8/21/18 3:19 AM, Thomas Hellstrom wrote: >>>   #include "vmwgfx_drv.h" >>>   #include "vmwgfx_reg.h" >>> @@ -4520,8 +4521,10 @@ int vmw_execbuf_ioctl(struct drm_device *dev, >>> unsigned long data, >>>   return -EINVAL; >>>   } >>> >>> -    if (arg.version > 1 && >>> - 

Re: [Linux-graphics-maintainer] [PATCH] drm/vmwgfx: Fix potential Spectre v1

2018-08-21 Thread Thomas Hellstrom
On 08/20/2018 10:53 PM, Deepak Singh Rawat wrote: Looks good to me based on my limited understanding. Thomas/Sinclair can could you please review and then we can include this in drm-fixes. Thanks, Deepak arg.version is indirectly controlled by user-space, hence leading to a potential

RE: [Linux-graphics-maintainer] [PATCH] drm/vmwgfx: Fix potential Spectre v1

2018-08-20 Thread Deepak Singh Rawat
Looks good to me based on my limited understanding. Thomas/Sinclair can could you please review and then we can include this in drm-fixes. Thanks, Deepak > > arg.version is indirectly controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. >

[PATCH] drm/vmwgfx: Fix potential Spectre v1

2018-08-17 Thread Gustavo A. R. Silva
arg.version is indirectly controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch: drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:4526 vmw_execbuf_ioctl() warn: potential spectre issue 'copy_offset' [w]