Re: [PATCH] drm: Add Grain Media GM12U320 driver v2

2019-07-30 Thread Hans de Goede
Hi, On 23-07-19 09:28, Sam Ravnborg wrote: Hi Hans. Driver looks good. Nce to see so much functionality in a driver less than 1000 loc. Following some bike-shedding only - that should have been sent for v1 already. But I thought better late then never. Thank you for the feedback I've prepare

Re: [PATCH] drm: Add Grain Media GM12U320 driver v2

2019-07-23 Thread Noralf Trønnes
Den 23.07.2019 09.33, skrev Daniel Vetter: > On Sun, Jul 21, 2019 at 03:25:25PM +0200, Hans de Goede wrote: >> Add a modesetting driver for Grain Media GM12U320 based devices >> (primarily Acer C120 projector, but there may be compatible devices). >> >> This is based on the fb driver from Viaches

Re: [PATCH] drm: Add Grain Media GM12U320 driver v2

2019-07-23 Thread Daniel Vetter
On Sun, Jul 21, 2019 at 03:25:25PM +0200, Hans de Goede wrote: > Add a modesetting driver for Grain Media GM12U320 based devices > (primarily Acer C120 projector, but there may be compatible devices). > > This is based on the fb driver from Viacheslav Nurmekhamitov: > https://github.com/slavrn/gm1

Re: [PATCH] drm: Add Grain Media GM12U320 driver v2

2019-07-23 Thread Sam Ravnborg
Hi Hans. Driver looks good. Nce to see so much functionality in a driver less than 1000 loc. Following some bike-shedding only - that should have been sent for v1 already. But I thought better late then never. Sam On Sun, Jul 21, 2019 at 03:25:25PM +0200, Hans de Goede wrote: > Add a mo

Re: [PATCH] drm: Add Grain Media GM12U320 driver v2

2019-07-21 Thread Hans de Goede
Hi all, On 21-07-19 15:25, Hans de Goede wrote: Add a modesetting driver for Grain Media GM12U320 based devices (primarily Acer C120 projector, but there may be compatible devices). This is based on the fb driver from Viacheslav Nurmekhamitov: https://github.com/slavrn/gm12u320 This driver use

[PATCH] drm: Add Grain Media GM12U320 driver v2

2019-07-21 Thread Hans de Goede
Add a modesetting driver for Grain Media GM12U320 based devices (primarily Acer C120 projector, but there may be compatible devices). This is based on the fb driver from Viacheslav Nurmekhamitov: https://github.com/slavrn/gm12u320 This driver uses drm_simple_display_pipe to deal with all the atom