An uninitialized return value is returned.
If the value is not necessary,
it would be better to return the constant 0.
Signed-off-by: Il Han corone.il@gmail.com
---
drivers/gpu/drm/nouveau/nv04_fence.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git
On Sun, Jun 3, 2012 at 6:41 PM, Il Han corone.il@gmail.com wrote:
An uninitialized return value is returned.
If the value is not necessary,
it would be better to return the constant 0.
Signed-off-by: Il Han corone.il@gmail.com
---
drivers/gpu/drm/nouveau/nv04_fence.c |3 +--
On Sun, Jun 3, 2012 at 6:41 PM, Il Han corone.il@gmail.com wrote:
An uninitialized return value is returned.
If the value is not necessary,
it would be better to return the constant 0.
Signed-off-by: Il Han corone.il@gmail.com
---
drivers/gpu/drm/nouveau/nv04_fence.c | 3 +--
1
On Sun, Jun 3, 2012 at 2:26 PM, bing deng deng8b...@gmail.com wrote:
Hi All,
Why not modify int ret; to int ret = 0;? Below is the benefit:
1. return the constant 0 as wish.
2. The variable ret can be used if we want.
Why? ret is in vain and wastes memory...
--
Thanks,
//richard
On Sun, Jun 3, 2012 at 6:41 PM, Il Han wrote:
> An uninitialized return value is returned.
> If the value is not necessary,
> it would be better to return the constant 0.
>
> Signed-off-by: Il Han
> ---
> ?drivers/gpu/drm/nouveau/nv04_fence.c | ? ?3 +--
> ?1 files changed, 1 insertions(+), 2
On Sun, Jun 3, 2012 at 6:41 PM, Il Han wrote:
> An uninitialized return value is returned.
> If the value is not necessary,
> it would be better to return the constant 0.
>
> Signed-off-by: Il Han
> ---
> drivers/gpu/drm/nouveau/nv04_fence.c |3 +--
> 1 files changed, 1 insertions(+), 2
On Sun, Jun 3, 2012 at 2:26 PM, bing deng wrote:
> Hi All,
>
> ? ?Why not modify "int ret;" to "int ret = 0;"? Below is the benefit:
> ? ?1. return the constant 0 as wish.
> ? ?2. The variable ret can be used if we want.
Why? ret is in vain and wastes memory...
--
Thanks,
//richard