Re: [PATCH] drm: Constify mode argument to connector .mode_valid() helper operation

2018-06-18 Thread Daniel Vetter
On Mon, Jun 11, 2018 at 07:51:01PM +0300, Ville Syrjälä wrote: > On Thu, Jun 07, 2018 at 03:13:23PM +0300, Laurent Pinchart wrote: > > Hi Ville, > > > > On Thursday, 7 June 2018 15:03:12 EEST Ville Syrjälä wrote: > > > On Wed, Jun 06, 2018 at 12:08:12PM +0300, Laurent Pinchart wrote: > > > > The

Re: [PATCH] drm: Constify mode argument to connector .mode_valid() helper operation

2018-06-11 Thread Ville Syrjälä
On Thu, Jun 07, 2018 at 03:13:23PM +0300, Laurent Pinchart wrote: > Hi Ville, > > On Thursday, 7 June 2018 15:03:12 EEST Ville Syrjälä wrote: > > On Wed, Jun 06, 2018 at 12:08:12PM +0300, Laurent Pinchart wrote: > > > The drm_connector_helper_funcs .mode_valid() operation should not modify > > >

Re: [PATCH] drm: Constify mode argument to connector .mode_valid() helper operation

2018-06-07 Thread Laurent Pinchart
Hi Ville, On Thursday, 7 June 2018 15:03:12 EEST Ville Syrjälä wrote: > On Wed, Jun 06, 2018 at 12:08:12PM +0300, Laurent Pinchart wrote: > > The drm_connector_helper_funcs .mode_valid() operation should not modify > > the mode it receives in any way. To make this explicit, constify the > > mode

Re: [PATCH] drm: Constify mode argument to connector .mode_valid() helper operation

2018-06-07 Thread Tomi Valkeinen
On 07/06/18 15:03, Ville Syrjälä wrote: > On Wed, Jun 06, 2018 at 12:08:12PM +0300, Laurent Pinchart wrote: >> The drm_connector_helper_funcs .mode_valid() operation should not modify >> the mode it receives in any way. To make this explicit, constify the >> mode pointer as done for all other

Re: [PATCH] drm: Constify mode argument to connector .mode_valid() helper operation

2018-06-07 Thread Ville Syrjälä
On Wed, Jun 06, 2018 at 12:08:12PM +0300, Laurent Pinchart wrote: > The drm_connector_helper_funcs .mode_valid() operation should not modify > the mode it receives in any way. To make this explicit, constify the > mode pointer as done for all other .mode_valid() operations, and update > all

[PATCH] drm: Constify mode argument to connector .mode_valid() helper operation

2018-06-06 Thread Laurent Pinchart
The drm_connector_helper_funcs .mode_valid() operation should not modify the mode it receives in any way. To make this explicit, constify the mode pointer as done for all other .mode_valid() operations, and update all drivers accordingly. Signed-off-by: Laurent Pinchart --- This patch touches