Re: [PATCH] drm: Fix page flip ioctl format check

2020-05-11 Thread Ville Syrjälä
On Mon, May 11, 2020 at 02:41:13PM +0200, Daniel Vetter wrote: > On Mon, May 11, 2020 at 2:37 PM Ville Syrjälä > wrote: > > > > On Sat, May 09, 2020 at 12:13:02PM +0200, Daniel Vetter wrote: > > > On Fri, May 8, 2020 at 7:09 PM Rodrigo Vivi > > > wrote: > > > > > > > > On Fri, Apr 17, 2020 at

Re: [PATCH] drm: Fix page flip ioctl format check

2020-05-11 Thread Daniel Vetter
On Mon, May 11, 2020 at 2:37 PM Ville Syrjälä wrote: > > On Sat, May 09, 2020 at 12:13:02PM +0200, Daniel Vetter wrote: > > On Fri, May 8, 2020 at 7:09 PM Rodrigo Vivi wrote: > > > > > > On Fri, Apr 17, 2020 at 09:28:34PM +0300, Ville Syrjälä wrote: > > > > On Fri, Apr 17, 2020 at 08:10:26PM

Re: [PATCH] drm: Fix page flip ioctl format check

2020-05-11 Thread Ville Syrjälä
On Sat, May 09, 2020 at 12:13:02PM +0200, Daniel Vetter wrote: > On Fri, May 8, 2020 at 7:09 PM Rodrigo Vivi wrote: > > > > On Fri, Apr 17, 2020 at 09:28:34PM +0300, Ville Syrjälä wrote: > > > On Fri, Apr 17, 2020 at 08:10:26PM +0200, Daniel Vetter wrote: > > > > On Fri, Apr 17, 2020 at 5:43 PM

Re: [PATCH] drm: Fix page flip ioctl format check

2020-05-09 Thread Daniel Vetter
On Fri, May 8, 2020 at 7:09 PM Rodrigo Vivi wrote: > > On Fri, Apr 17, 2020 at 09:28:34PM +0300, Ville Syrjälä wrote: > > On Fri, Apr 17, 2020 at 08:10:26PM +0200, Daniel Vetter wrote: > > > On Fri, Apr 17, 2020 at 5:43 PM Ville Syrjälä > > > wrote: > > > > > > > > On Fri, Apr 17, 2020 at

Re: [PATCH] drm: Fix page flip ioctl format check

2020-05-08 Thread Rodrigo Vivi
On Fri, Apr 17, 2020 at 09:28:34PM +0300, Ville Syrjälä wrote: > On Fri, Apr 17, 2020 at 08:10:26PM +0200, Daniel Vetter wrote: > > On Fri, Apr 17, 2020 at 5:43 PM Ville Syrjälä > > wrote: > > > > > > On Fri, Apr 17, 2020 at 05:23:10PM +0200, Daniel Vetter wrote: > > > > On Thu, Apr 16, 2020 at

Re: [PATCH] drm: Fix page flip ioctl format check

2020-04-17 Thread Ville Syrjälä
On Fri, Apr 17, 2020 at 08:10:26PM +0200, Daniel Vetter wrote: > On Fri, Apr 17, 2020 at 5:43 PM Ville Syrjälä > wrote: > > > > On Fri, Apr 17, 2020 at 05:23:10PM +0200, Daniel Vetter wrote: > > > On Thu, Apr 16, 2020 at 08:04:20PM +0300, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > > >

Re: [PATCH] drm: Fix page flip ioctl format check

2020-04-17 Thread Daniel Vetter
On Fri, Apr 17, 2020 at 5:43 PM Ville Syrjälä wrote: > > On Fri, Apr 17, 2020 at 05:23:10PM +0200, Daniel Vetter wrote: > > On Thu, Apr 16, 2020 at 08:04:20PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Revert back to comparing fb->format->format instead fb->format for the

Re: [PATCH] drm: Fix page flip ioctl format check

2020-04-17 Thread Ville Syrjälä
On Fri, Apr 17, 2020 at 05:23:10PM +0200, Daniel Vetter wrote: > On Thu, Apr 16, 2020 at 08:04:20PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Revert back to comparing fb->format->format instead fb->format for the > > page flip ioctl. This check was originally only here to

Re: [PATCH] drm: Fix page flip ioctl format check

2020-04-17 Thread Daniel Vetter
On Thu, Apr 16, 2020 at 08:04:20PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Revert back to comparing fb->format->format instead fb->format for the > page flip ioctl. This check was originally only here to disallow pixel > format changes, but when we changed it to do the pointer

RE: [PATCH] drm: Fix page flip ioctl format check

2020-04-17 Thread Kadiyala, Kishore
> -Original Message- > From: dri-devel On Behalf Of Ville > Syrjala > Sent: Thursday, April 16, 2020 10:34 PM > To: dri-devel@lists.freedesktop.org > Cc: intel-...@lists.freedesktop.org; Laurent Pinchart > ; sta...@vger.kernel.org > Subject: [PATCH] drm: Fix page

Re: [PATCH] drm: Fix page flip ioctl format check

2020-04-16 Thread Ville Syrjälä
On Thu, Apr 16, 2020 at 08:08:14PM +0300, Laurent Pinchart wrote: > Hi Ville, > > Thank you for the patch. > > On Thu, Apr 16, 2020 at 08:04:20PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Revert back to comparing fb->format->format instead fb->format for the > > page flip

Re: [PATCH] drm: Fix page flip ioctl format check

2020-04-16 Thread Laurent Pinchart
Hi Ville, Thank you for the patch. On Thu, Apr 16, 2020 at 08:04:20PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Revert back to comparing fb->format->format instead fb->format for the > page flip ioctl. This check was originally only here to disallow pixel > format changes, but when

[PATCH] drm: Fix page flip ioctl format check

2020-04-16 Thread Ville Syrjala
From: Ville Syrjälä Revert back to comparing fb->format->format instead fb->format for the page flip ioctl. This check was originally only here to disallow pixel format changes, but when we changed it to do the pointer comparison we potentially started to reject some (but definitely not all)