Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-21 Thread Patrik Jakobsson
On Wed, Oct 19, 2022 at 1:11 PM andriy.shevche...@linux.intel.com wrote: > > On Wed, Oct 19, 2022 at 09:32:26AM +0200, Thomas Zimmermann wrote: > > Am 18.10.22 um 17:52 schrieb Zack Rusin: > > > IIRC PSB hardware is only available in 32-bit systems. > > Dunno about deep details, but IIUC the

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-19 Thread Thomas Zimmermann
Am 19.10.22 um 13:08 schrieb andriy.shevche...@linux.intel.com: On Wed, Oct 19, 2022 at 09:32:26AM +0200, Thomas Zimmermann wrote: Am 18.10.22 um 17:52 schrieb Zack Rusin: IIRC PSB hardware is only available in 32-bit systems. Dunno about deep details, but IIUC the Intel Tangier and

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-19 Thread andriy.shevche...@linux.intel.com
On Wed, Oct 19, 2022 at 09:32:26AM +0200, Thomas Zimmermann wrote: > Am 18.10.22 um 17:52 schrieb Zack Rusin: > IIRC PSB hardware is only available in 32-bit systems. Dunno about deep details, but IIUC the Intel Tangier and Intel Annioedale are 64-bit SoCs that have Imagination + Intel IPs, the

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-19 Thread Thomas Zimmermann
Hi Am 18.10.22 um 17:52 schrieb Zack Rusin: [...] @@ -527,7 +527,7 @@ void psb_modeset_init(struct drm_device *dev) /* set memory base */ /* Oaktrail and Poulsbo should use BAR 2*/ - pci_read_config_dword(pdev, PSB_BSM, (u32 *)&(dev->mode_config.fb_base)); +

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
On Tue, 2022-10-18 at 16:05 +0200, Thomas Zimmermann wrote: > Hi > > Am 18.10.22 um 15:17 schrieb Zack Rusin: > > From: Zack Rusin > > > > The fb_base in struct drm_mode_config has been unused for a long time. > > Some drivers set it and some don't leading to a very confusing state > > where

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Laurent Pinchart
Hi Zack, Thank you for the patch. On Tue, Oct 18, 2022 at 09:17:45AM -0400, Zack Rusin wrote: > From: Zack Rusin > > The fb_base in struct drm_mode_config has been unused for a long time. > Some drivers set it and some don't leading to a very confusing state > where the variable can't be

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Christian König
Am 18.10.22 um 15:17 schrieb Zack Rusin: From: Zack Rusin The fb_base in struct drm_mode_config has been unused for a long time. Some drivers set it and some don't leading to a very confusing state where the variable can't be relied upon, because there's no indication as to which driver sets

Re: [PATCH] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Thomas Zimmermann
Hi Am 18.10.22 um 15:17 schrieb Zack Rusin: From: Zack Rusin The fb_base in struct drm_mode_config has been unused for a long time. Some drivers set it and some don't leading to a very confusing state where the variable can't be relied upon, because there's no indication as to which driver

[PATCH] drm: Remove drm_mode_config::fb_base

2022-10-18 Thread Zack Rusin
From: Zack Rusin The fb_base in struct drm_mode_config has been unused for a long time. Some drivers set it and some don't leading to a very confusing state where the variable can't be relied upon, because there's no indication as to which driver sets it and which doesn't. The only usage of