We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/amd/amdgpu/si.c:908:5: warning: no previous prototype for
'si_pciep_rreg' [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/si.c:921:6: warning: no previous prototype for
'si_pciep_wreg' [-Wmissing-prototypes]
In fact, these functi
On Mon, Sep 19, 2016 at 6:01 AM, Christian König
wrote:
> Am 18.09.2016 um 16:09 schrieb Baoyou Xie:
>>
>> We get 7 warnings when building kernel with W=1:
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1990:5: warning: no previous
>> prototype for 'amdgpu_pre_soft_reset' [-Wmissing-prototypes]
>>
Am 18.09.2016 um 16:09 schrieb Baoyou Xie:
> We get 7 warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1990:5: warning: no previous
> prototype for 'amdgpu_pre_soft_reset' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c:1548:5: warning: n
We get 7 warnings when building kernel with W=1:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1990:5: warning: no previous
prototype for 'amdgpu_pre_soft_reset' [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c:1548:5: warning: no previous
prototype for 'amdgpu_connector_virtual
On Sat, Sep 03, 2016 at 01:57:14PM +0800, Baoyou Xie wrote:
> We get a few warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/cz_smc.c:51:5: warning: no previous prototype for
> 'cz_send_msg_to_smc_async' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/cz_smc.c:143:5: warning
On 09/03/2016 04:23 PM, Baoyou Xie wrote:
> in drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c and
> drivers/gpu/drm/amd/amdgpu/cz_smc.c, there are two functions named
> cz_write_smc_sram_dword, but these two functions only have the same
> name, but in fact they are different functions, even the
Reviewed-by: Edward O'Callaghan
Also, I just noticed cz_write_smc_sram_dword() and if I am not mistaken
they seems identical in both:
drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c and,
drivers/gpu/drm/amd/amdgpu/cz_smc.c
with a personal preference to the powerplay version I suppose.
Simi
of course, if we really need to cleanup the code in
drivers/gpu/drm/amd/powerplay and drivers/gpu/drm/amd/amdgpu, sounds good :)
On 3 September 2016 at 14:11, Edward O'Callaghan <
funfunctor at folklore1984.net> wrote:
> Reviewed-by: Edward O'Callaghan
>
> Also, I just noticed cz_write_smc_sram_
in drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c and
drivers/gpu/drm/amd/amdgpu/cz_smc.c, there are two functions named
cz_write_smc_sram_dword, but these two functions only have the same name,
but in fact they are different functions, even their declarations is
different.
On 3 September 2016 a
We get a few warnings when building kernel with W=1:
drivers/gpu/drm/amd/amdgpu/cz_smc.c:51:5: warning: no previous prototype for
'cz_send_msg_to_smc_async' [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/cz_smc.c:143:5: warning: no previous prototype for
'cz_write_smc_sram_dword' [-Wmissing-pr
Am 03.09.2016 um 07:57 schrieb Baoyou Xie:
> We get a few warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/cz_smc.c:51:5: warning: no previous prototype for
> 'cz_send_msg_to_smc_async' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/cz_smc.c:143:5: warning: no previous pro
11 matches
Mail list logo