Re: [PATCH] drm: rcar-du: Fix the return check of of_parse_phandle and of_find_device_by_node

2020-12-15 Thread Laurent Pinchart
On Wed, Dec 16, 2020 at 03:00:43AM +0200, Laurent Pinchart wrote: > Hi Wang, > > Thank you for the patch. > > On Wed, Nov 11, 2020 at 11:14:52AM +0800, Wang Xiaojun wrote: > > of_parse_phandle and of_find_device_by_node may return NULL > > which cannot be checked by IS_ERR. > > > > Signed-off-by

Re: [PATCH] drm: rcar-du: Fix the return check of of_parse_phandle and of_find_device_by_node

2020-12-15 Thread Laurent Pinchart
Hi Wang, Thank you for the patch. On Wed, Nov 11, 2020 at 11:14:52AM +0800, Wang Xiaojun wrote: > of_parse_phandle and of_find_device_by_node may return NULL > which cannot be checked by IS_ERR. > > Signed-off-by: Wang Xiaojun > Reported-by: Hulk Robot Reviewed-by: Laurent Pinchart and queu

Re: [PATCH] drm: rcar-du: Fix the return check of of_parse_phandle and of_find_device_by_node

2020-11-11 Thread Kieran Bingham
Hi Wang Xiaojun, On 11/11/2020 03:14, Wang Xiaojun wrote: > of_parse_phandle and of_find_device_by_node may return NULL > which cannot be checked by IS_ERR. Indeed, both of these functions return either NULL or the correct value, and no an errno. > > Signed-off-by: Wang Xiaojun > Reported-by:

[PATCH] drm: rcar-du: Fix the return check of of_parse_phandle and of_find_device_by_node

2020-11-10 Thread Wang Xiaojun
of_parse_phandle and of_find_device_by_node may return NULL which cannot be checked by IS_ERR. Signed-off-by: Wang Xiaojun Reported-by: Hulk Robot --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_d