Re: [PATCH] drm: vc4: adapt to new behaviour of drm_crtc.c

2017-02-08 Thread Eric Anholt
Andrzej Pietrasiewicz writes: > Hi Eric, > > W dniu 08.02.2017 o 01:33, Eric Anholt pisze: >> Andrzej Pietrasiewicz writes: >> > > > >> >> Thanks for the detailed explanation! >> >> I think the cursor's possible_crtcs is getting set in vc4_crtc.c (since >> we don't pass the cursor into drm_crtc

Re: [PATCH] drm: vc4: adapt to new behaviour of drm_crtc.c

2017-02-08 Thread Andrzej Pietrasiewicz
Hi Eric, W dniu 08.02.2017 o 01:33, Eric Anholt pisze: Andrzej Pietrasiewicz writes: Thanks for the detailed explanation! I think the cursor's possible_crtcs is getting set in vc4_crtc.c (since we don't pass the cursor into drm_crtc_init_with_planes()). You are right. Shall I submit a

Re: [PATCH] drm: vc4: adapt to new behaviour of drm_crtc.c

2017-02-07 Thread Daniel Vetter
On Wed, Feb 8, 2017 at 1:33 AM, Eric Anholt wrote: > Andrzej Pietrasiewicz writes: > >> When drm_crtc_init_with_planes() was orignally added >> (in drm_crtc.c, e13161af80c185ecd8dc4641d0f5df58f9e3e0af >> drm: Add drm_crtc_init_with_planes() (v2)), it only checked for "primary" >> being non-null.

Re: [PATCH] drm: vc4: adapt to new behaviour of drm_crtc.c

2017-02-07 Thread Eric Anholt
Andrzej Pietrasiewicz writes: > When drm_crtc_init_with_planes() was orignally added > (in drm_crtc.c, e13161af80c185ecd8dc4641d0f5df58f9e3e0af > drm: Add drm_crtc_init_with_planes() (v2)), it only checked for "primary" > being non-null. If that was the case, it modified primary->possible_crtcs.

[PATCH] drm: vc4: adapt to new behaviour of drm_crtc.c

2017-02-01 Thread Andrzej Pietrasiewicz
When drm_crtc_init_with_planes() was orignally added (in drm_crtc.c, e13161af80c185ecd8dc4641d0f5df58f9e3e0af drm: Add drm_crtc_init_with_planes() (v2)), it only checked for "primary" being non-null. If that was the case, it modified primary->possible_crtcs. Then, when support for cursor planes wa