Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-11 Thread Michel Dänzer
On 4/11/23 11:10, Geert Uytterhoeven wrote: > Hi Michel, > > On Wed, Apr 5, 2023 at 10:50 AM Michel Dänzer > wrote: >> On 4/4/23 14:36, Daniel Vetter wrote: >>> There's a few reasons the kernel should not spam dmesg on bad >>> userspace ioctl input: >>> - at warning level it results in CI false

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-11 Thread Geert Uytterhoeven
Hi Michel, On Wed, Apr 5, 2023 at 10:50 AM Michel Dänzer wrote: > On 4/4/23 14:36, Daniel Vetter wrote: > > There's a few reasons the kernel should not spam dmesg on bad > > userspace ioctl input: > > - at warning level it results in CI false positives > > - it allows userspace to drown dmesg

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-05 Thread Michel Dänzer
On 4/4/23 14:36, Daniel Vetter wrote: > There's a few reasons the kernel should not spam dmesg on bad > userspace ioctl input: > - at warning level it results in CI false positives > - it allows userspace to drown dmesg output, potentially hiding real > issues. > > None of the other generic

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Daniel Vetter
On Tue, 4 Apr 2023 at 19:04, Geert Uytterhoeven wrote: > > Hi Daniel, > > On Tue, Apr 4, 2023 at 5:55 PM Daniel Vetter wrote: > > On Tue, 4 Apr 2023 at 16:51, Geert Uytterhoeven > > wrote: > > > On Tue, Apr 4, 2023 at 4:19 PM Daniel Vetter wrote: > > > > On Tue, Apr 04, 2023 at 03:59:12PM

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Geert Uytterhoeven
Hi Daniel, On Tue, Apr 4, 2023 at 5:55 PM Daniel Vetter wrote: > On Tue, 4 Apr 2023 at 16:51, Geert Uytterhoeven wrote: > > On Tue, Apr 4, 2023 at 4:19 PM Daniel Vetter wrote: > > > On Tue, Apr 04, 2023 at 03:59:12PM +0200, Daniel Vetter wrote: > > > > On Tue, Apr 04, 2023 at 03:53:09PM +0200,

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Daniel Vetter
On Tue, 4 Apr 2023 at 16:51, Geert Uytterhoeven wrote: > > CC linux-fbdev > > On Tue, Apr 4, 2023 at 4:19 PM Daniel Vetter wrote: > > On Tue, Apr 04, 2023 at 03:59:12PM +0200, Daniel Vetter wrote: > > > On Tue, Apr 04, 2023 at 03:53:09PM +0200, Geert Uytterhoeven wrote: > > > > On Tue, Apr 4,

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Geert Uytterhoeven
CC linux-fbdev On Tue, Apr 4, 2023 at 4:41 PM Thomas Zimmermann wrote: > Am 04.04.23 um 16:19 schrieb Daniel Vetter: > > On Tue, Apr 04, 2023 at 03:59:12PM +0200, Daniel Vetter wrote: > >> On Tue, Apr 04, 2023 at 03:53:09PM +0200, Geert Uytterhoeven wrote: > >>> CC vkmsdrm maintainer > >>> > >>>

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Geert Uytterhoeven
CC linux-fbdev On Tue, Apr 4, 2023 at 4:19 PM Daniel Vetter wrote: > On Tue, Apr 04, 2023 at 03:59:12PM +0200, Daniel Vetter wrote: > > On Tue, Apr 04, 2023 at 03:53:09PM +0200, Geert Uytterhoeven wrote: > > > On Tue, Apr 4, 2023 at 2:36 PM Daniel Vetter > > > wrote: > > > > There's a few

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Thomas Zimmermann
Hi Am 04.04.23 um 16:19 schrieb Daniel Vetter: On Tue, Apr 04, 2023 at 03:59:12PM +0200, Daniel Vetter wrote: On Tue, Apr 04, 2023 at 03:53:09PM +0200, Geert Uytterhoeven wrote: Hi Daniel, CC vkmsdrm maintainer Thanks for your patch! On Tue, Apr 4, 2023 at 2:36 PM Daniel Vetter wrote:

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Daniel Vetter
On Tue, Apr 04, 2023 at 03:59:12PM +0200, Daniel Vetter wrote: > On Tue, Apr 04, 2023 at 03:53:09PM +0200, Geert Uytterhoeven wrote: > > Hi Daniel, > > > > CC vkmsdrm maintainer > > > > Thanks for your patch! > > > > On Tue, Apr 4, 2023 at 2:36 PM Daniel Vetter wrote: > > > There's a few

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Daniel Vetter
On Tue, Apr 04, 2023 at 03:53:09PM +0200, Geert Uytterhoeven wrote: > Hi Daniel, > > CC vkmsdrm maintainer > > Thanks for your patch! > > On Tue, Apr 4, 2023 at 2:36 PM Daniel Vetter wrote: > > There's a few reasons the kernel should not spam dmesg on bad > > userspace ioctl input: > > - at

Re: [PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Geert Uytterhoeven
Hi Daniel, CC vkmsdrm maintainer Thanks for your patch! On Tue, Apr 4, 2023 at 2:36 PM Daniel Vetter wrote: > There's a few reasons the kernel should not spam dmesg on bad > userspace ioctl input: > - at warning level it results in CI false positives > - it allows userspace to drown dmesg

[PATCH] fbdev: Don't spam dmesg on bad userspace ioctl input

2023-04-04 Thread Daniel Vetter
There's a few reasons the kernel should not spam dmesg on bad userspace ioctl input: - at warning level it results in CI false positives - it allows userspace to drown dmesg output, potentially hiding real issues. None of the other generic EINVAL checks report in the FBIOPUT_VSCREENINFO ioctl