[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-10 Thread Takashi Iwai
At Thu, 10 Mar 2011 11:06:28 +0100 (CET), Indan Zupancic wrote: > > On Thu, March 10, 2011 09:25, Takashi Iwai wrote: > > At Thu, 10 Mar 2011 08:49:37 +0100, > > Takashi Iwai wrote: > >> > >> At Thu, 10 Mar 2011 06:50:09 +0100 (CET), > >> Indan Zupancic wrote: > >> > > >> > Hello, > >> > > >> >

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-10 Thread Takashi Iwai
At Thu, 10 Mar 2011 09:45:18 +0100 (CET), Indan Zupancic wrote: > > On Thu, March 10, 2011 08:49, Takashi Iwai wrote: > > At Thu, 10 Mar 2011 06:50:09 +0100 (CET), > > Indan Zupancic wrote: > >> > >> Hello, > >> > >> On Fri, March 4, 2011 19:47, Linus Torvalds wrote: > >> > Alex, can you confirm

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-10 Thread Indan Zupancic
On Thu, March 10, 2011 09:25, Takashi Iwai wrote: > At Thu, 10 Mar 2011 08:49:37 +0100, > Takashi Iwai wrote: >> >> At Thu, 10 Mar 2011 06:50:09 +0100 (CET), >> Indan Zupancic wrote: >> > >> > Hello, >> > >> > On Fri, March 4, 2011 19:47, Linus Torvalds wrote: >> > > Alex, can you confirm that the

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-10 Thread Indan Zupancic
On Thu, March 10, 2011 08:49, Takashi Iwai wrote: > At Thu, 10 Mar 2011 06:50:09 +0100 (CET), > Indan Zupancic wrote: >> >> Hello, >> >> On Fri, March 4, 2011 19:47, Linus Torvalds wrote: >> > Alex, can you confirm that the revert of 951f3512dba5 plus the >> > one-liner patch from Takashi that

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-10 Thread Takashi Iwai
At Thu, 10 Mar 2011 08:49:37 +0100, Takashi Iwai wrote: > > At Thu, 10 Mar 2011 06:50:09 +0100 (CET), > Indan Zupancic wrote: > > > > Hello, > > > > On Fri, March 4, 2011 19:47, Linus Torvalds wrote: > > > Alex, can you confirm that the revert of 951f3512dba5 plus the > > > one-liner patch from

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-10 Thread Takashi Iwai
At Thu, 10 Mar 2011 06:50:09 +0100 (CET), Indan Zupancic wrote: > > Hello, > > On Fri, March 4, 2011 19:47, Linus Torvalds wrote: > > Alex, can you confirm that the revert of 951f3512dba5 plus the > > one-liner patch from Takashi that Indan quoted also works for you? > > > > Linus

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-10 Thread Indan Zupancic
drm/i915: Fix DPMS and suspend interaction for intel_panel.c When suspending intel_panel_disable_backlight() is never called, but intel_panel_enable_backlight() is called at resume. With the effect that if the brightness was ever changed after screen blanking, the wrong brightness gets restored

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-10 Thread Indan Zupancic
Hello, On Fri, March 4, 2011 19:47, Linus Torvalds wrote: > Alex, can you confirm that the revert of 951f3512dba5 plus the > one-liner patch from Takashi that Indan quoted also works for you? > > Linus > > On Thu, Mar 3, 2011 at 10:53 PM, Indan Zupancic wrote: >> >> So please

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-10 Thread Takashi Iwai
At Thu, 10 Mar 2011 08:49:37 +0100, Takashi Iwai wrote: At Thu, 10 Mar 2011 06:50:09 +0100 (CET), Indan Zupancic wrote: Hello, On Fri, March 4, 2011 19:47, Linus Torvalds wrote: Alex, can you confirm that the revert of 951f3512dba5 plus the one-liner patch from Takashi that

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-10 Thread Indan Zupancic
On Thu, March 10, 2011 08:49, Takashi Iwai wrote: At Thu, 10 Mar 2011 06:50:09 +0100 (CET), Indan Zupancic wrote: Hello, On Fri, March 4, 2011 19:47, Linus Torvalds wrote: Alex, can you confirm that the revert of 951f3512dba5 plus the one-liner patch from Takashi that Indan quoted also

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-10 Thread Indan Zupancic
On Thu, March 10, 2011 09:25, Takashi Iwai wrote: At Thu, 10 Mar 2011 08:49:37 +0100, Takashi Iwai wrote: At Thu, 10 Mar 2011 06:50:09 +0100 (CET), Indan Zupancic wrote: Hello, On Fri, March 4, 2011 19:47, Linus Torvalds wrote: Alex, can you confirm that the revert of 951f3512dba5

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-10 Thread Takashi Iwai
At Thu, 10 Mar 2011 09:45:18 +0100 (CET), Indan Zupancic wrote: On Thu, March 10, 2011 08:49, Takashi Iwai wrote: At Thu, 10 Mar 2011 06:50:09 +0100 (CET), Indan Zupancic wrote: Hello, On Fri, March 4, 2011 19:47, Linus Torvalds wrote: Alex, can you confirm that the revert of

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-10 Thread Takashi Iwai
At Thu, 10 Mar 2011 11:06:28 +0100 (CET), Indan Zupancic wrote: On Thu, March 10, 2011 09:25, Takashi Iwai wrote: At Thu, 10 Mar 2011 08:49:37 +0100, Takashi Iwai wrote: At Thu, 10 Mar 2011 06:50:09 +0100 (CET), Indan Zupancic wrote: Hello, On Fri, March 4, 2011 19:47,

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-09 Thread Indan Zupancic
Hello, On Fri, March 4, 2011 19:47, Linus Torvalds wrote: Alex, can you confirm that the revert of 951f3512dba5 plus the one-liner patch from Takashi that Indan quoted also works for you? Linus On Thu, Mar 3, 2011 at 10:53 PM, Indan Zupancic in...@nul.nu wrote: So please

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-06 Thread Alex Riesen
On Fri, Mar 4, 2011 at 19:47, Linus Torvalds wrote: > Alex, can you confirm that the revert of 951f3512dba5 plus the > one-liner patch from Takashi that Indan quoted also works for you? I afraid mine is a different case, because backlight in this system works properly even with Indan's patch

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-06 Thread Alex Riesen
On Fri, Mar 4, 2011 at 19:47, Linus Torvalds torva...@linux-foundation.org wrote: Alex, can you confirm that the revert of 951f3512dba5 plus the one-liner patch from Takashi that Indan quoted also works for you? I afraid mine is a different case, because backlight in this system works properly

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-05 Thread Peter Stuge
Indan Zupancic wrote: > What I don't understand is how BIOS makers could know about those bits. They have relationships with Intel since 30 years, ie. they get what they need in one form or other. //Peter

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-05 Thread Indan Zupancic
On Fri, March 4, 2011 19:47, Linus Torvalds wrote: > Alex, can you confirm that the revert of 951f3512dba5 plus the > one-liner patch from Takashi that Indan quoted also works for you? > > Linus > > On Thu, Mar 3, 2011 at 10:53 PM, Indan Zupancic wrote: >> >> So please revert my

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-04 Thread Linus Torvalds
Alex, can you confirm that the revert of 951f3512dba5 plus the one-liner patch from Takashi that Indan quoted also works for you? Linus On Thu, Mar 3, 2011 at 10:53 PM, Indan Zupancic wrote: > > So please revert my patch and apply Takashi Iwai's, which fixes the > most immediate

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-04 Thread Indan Zupancic
Hello, On Wed, February 23, 2011 02:09, Linus Torvalds wrote: > On Tue, Feb 22, 2011 at 2:31 PM, Tino Keitel wrote: >> >> I just tried 2.6.38-rc6 on my ThinkPad X61s without any other DRM >> related patches, and my backlight issue is gone. > > I applied Indan's fix in -rc6 (commit 951f3512dba5),

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-04 Thread Linus Torvalds
Alex, can you confirm that the revert of 951f3512dba5 plus the one-liner patch from Takashi that Indan quoted also works for you? Linus On Thu, Mar 3, 2011 at 10:53 PM, Indan Zupancic in...@nul.nu wrote: So please revert my patch and apply Takashi Iwai's, which fixes the most

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-04 Thread Indan Zupancic
On Fri, March 4, 2011 19:47, Linus Torvalds wrote: Alex, can you confirm that the revert of 951f3512dba5 plus the one-liner patch from Takashi that Indan quoted also works for you? Linus On Thu, Mar 3, 2011 at 10:53 PM, Indan Zupancic in...@nul.nu wrote: So please revert my

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-04 Thread Peter Stuge
Indan Zupancic wrote: What I don't understand is how BIOS makers could know about those bits. They have relationships with Intel since 30 years, ie. they get what they need in one form or other. //Peter ___ dri-devel mailing list

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-03-03 Thread Indan Zupancic
Hello, On Wed, February 23, 2011 02:09, Linus Torvalds wrote: On Tue, Feb 22, 2011 at 2:31 PM, Tino Keitel tino.kei...@tikei.de wrote: I just tried 2.6.38-rc6 on my ThinkPad X61s without any other DRM related patches, and my backlight issue is gone. I applied Indan's fix in -rc6 (commit

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-23 Thread Indan Zupancic
On Tue, February 22, 2011 22:04, Jesse Barnes wrote: > On Sat, 19 Feb 2011 15:07:49 -0800 > Linus Torvalds wrote: > >> On Sat, Feb 19, 2011 at 4:26 AM, Alex Riesen wrote: >> > On Sat, Feb 19, 2011 at 13:11, Alex Riesen wrote: >> >>> Lastly, could you verify that my patch at >> >>>

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-22 Thread Tino Keitel
On Tue, Feb 22, 2011 at 13:04:40 -0800, Jesse Barnes wrote: > On Sat, 19 Feb 2011 15:07:49 -0800 > Linus Torvalds wrote: > > > On Sat, Feb 19, 2011 at 4:26 AM, Alex Riesen wrote: > > > On Sat, Feb 19, 2011 at 13:11, Alex Riesen wrote: > > >>> Lastly, could you verify that my patch at > > >>>

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-22 Thread Linus Torvalds
On Tue, Feb 22, 2011 at 2:31 PM, Tino Keitel wrote: > > I just tried 2.6.38-rc6 on my ThinkPad X61s without any other DRM > related patches, and my backlight issue is gone. I applied Indan's fix in -rc6 (commit 951f3512dba5), since it had several testers and seemed to simplify the code nicely

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-22 Thread Jesse Barnes
On Sat, 19 Feb 2011 15:07:49 -0800 Linus Torvalds wrote: > On Sat, Feb 19, 2011 at 4:26 AM, Alex Riesen wrote: > > On Sat, Feb 19, 2011 at 13:11, Alex Riesen wrote: > >>> Lastly, could you verify that my patch at > >>> https://lkml.org/lkml/2011/2/16/447 fixes > >>> it for you too? (Make sure

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-19 Thread Linus Torvalds
On Sat, Feb 19, 2011 at 4:26 AM, Alex Riesen wrote: > On Sat, Feb 19, 2011 at 13:11, Alex Riesen wrote: >>> Lastly, could you verify that my patch at >>> https://lkml.org/lkml/2011/2/16/447 fixes >>> it for you too? (Make sure you're at max brightness before rebooting.) >> >> I'll try it now.

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-19 Thread Alex Riesen
On Sat, Feb 19, 2011 at 13:11, Alex Riesen wrote: >> Lastly, could you verify that my patch at >> https://lkml.org/lkml/2011/2/16/447 fixes >> it for you too? (Make sure you're at max brightness before rebooting.) > > I'll try it now. > I can confirm that it does fix backlight in my case (Dell

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-19 Thread Alex Riesen
Sorry for this late answer. I only get a very little time for this. On Fri, Feb 18, 2011 at 05:57, Indan Zupancic wrote: > On Thu, February 17, 2011 23:13, Tino Keitel wrote: >> with kernel 2.6.37, the display brightness of my ThinkPad X61s was >> always reduced after lid open, resume from

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-19 Thread Alex Riesen
Sorry for this late answer. I only get a very little time for this. On Fri, Feb 18, 2011 at 05:57, Indan Zupancic in...@nul.nu wrote: On Thu, February 17, 2011 23:13, Tino Keitel wrote: with kernel 2.6.37, the display brightness of my ThinkPad X61s was always reduced after lid open, resume

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-19 Thread Alex Riesen
On Sat, Feb 19, 2011 at 13:11, Alex Riesen raa.l...@gmail.com wrote: Lastly, could you verify that my patch at https://lkml.org/lkml/2011/2/16/447 fixes it for you too? (Make sure you're at max brightness before rebooting.) I'll try it now. I can confirm that it does fix backlight in my

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-19 Thread Linus Torvalds
On Sat, Feb 19, 2011 at 4:26 AM, Alex Riesen raa.l...@gmail.com wrote: On Sat, Feb 19, 2011 at 13:11, Alex Riesen raa.l...@gmail.com wrote: Lastly, could you verify that my patch at https://lkml.org/lkml/2011/2/16/447 fixes it for you too? (Make sure you're at max brightness before

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-18 Thread Tino Keitel
On Wed, Feb 16, 2011 at 20:26:58 +0100, Alex Riesen wrote: > Signed-off-by: Alex Riesen > > --- > Linus Torvalds, Wed, Feb 16, 2011 05:16:01 +0100: > > Most of the changes are pretty spread out and small, with drivers/gpu > > (radeon and i915) somewhat standing out from the pack. ... > > The

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-18 Thread Indan Zupancic
On Thu, February 17, 2011 23:13, Tino Keitel wrote: > with kernel 2.6.37, the display brightness of my ThinkPad X61s was > always reduced after lid open, resume from suspend etc. With this > patch on top of 2.6.38-rc5, the problem is gone. Thanks. Tino, I think Alex's patch only hides the

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-17 Thread Tino Keitel
On Wed, Feb 16, 2011 at 20:26:58 +0100, Alex Riesen wrote: > Signed-off-by: Alex Riesen > > --- > Linus Torvalds, Wed, Feb 16, 2011 05:16:01 +0100: > > Most of the changes are pretty spread out and small, with drivers/gpu > > (radeon and i915) somewhat standing out from the pack. ... > > The

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-17 Thread Tino Keitel
On Wed, Feb 16, 2011 at 20:26:58 +0100, Alex Riesen wrote: Signed-off-by: Alex Riesen raa.l...@gmail.com --- Linus Torvalds, Wed, Feb 16, 2011 05:16:01 +0100: Most of the changes are pretty spread out and small, with drivers/gpu (radeon and i915) somewhat standing out from the pack. ...

Re: [PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-17 Thread Indan Zupancic
On Thu, February 17, 2011 23:13, Tino Keitel wrote: with kernel 2.6.37, the display brightness of my ThinkPad X61s was always reduced after lid open, resume from suspend etc. With this patch on top of 2.6.38-rc5, the problem is gone. Thanks. Tino, I think Alex's patch only hides the problem

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-16 Thread Alex Riesen
On Wed, Feb 16, 2011 at 21:05, Jesse Barnes wrote: > On Wed, 16 Feb 2011 20:59:35 +0100 > Alex Riesen wrote: >> >> I don't think it is related. I don't have problems switching >> the outputs (frankly, didn't try) and I do have problems >> restoring backlight, very similar to what I had earlier

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-16 Thread Alex Riesen
On Wed, Feb 16, 2011 at 20:54, Jesse Barnes wrote: > On Wed, 16 Feb 2011 20:46:45 +0100 > Alex Riesen wrote: >> > The backlight level on this Dell XPS M1330 reduces every time I reopen >> > the lid, and BIOS does not seem to know anything about that (the >> > keyboard shortcuts to set backlight

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-16 Thread Alex Riesen
On Wed, Feb 16, 2011 at 20:26, Alex Riesen wrote: > Linus Torvalds, Wed, Feb 16, 2011 05:16:01 +0100: >> Most of the changes are pretty spread out and small, with drivers/gpu >> (radeon and i915) somewhat standing out from the pack. ... > > The backlight level on this Dell XPS M1330 reduces every

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-16 Thread Alex Riesen
Signed-off-by: Alex Riesen --- Linus Torvalds, Wed, Feb 16, 2011 05:16:01 +0100: > Most of the changes are pretty spread out and small, with drivers/gpu > (radeon and i915) somewhat standing out from the pack. ... The backlight level on this Dell XPS M1330 reduces every time I reopen the lid,

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-16 Thread Jesse Barnes
On Wed, 16 Feb 2011 20:59:35 +0100 Alex Riesen wrote: > On Wed, Feb 16, 2011 at 20:54, Jesse Barnes > wrote: > > On Wed, 16 Feb 2011 20:46:45 +0100 > > Alex Riesen wrote: > >> > The backlight level on this Dell XPS M1330 reduces every time I reopen > >> > the lid, and BIOS does not seem to

[PATCH] fix backlight brightness on intel LVDS panel after reopening lid

2011-02-16 Thread Jesse Barnes
On Wed, 16 Feb 2011 20:46:45 +0100 Alex Riesen wrote: > On Wed, Feb 16, 2011 at 20:26, Alex Riesen wrote: > > Linus Torvalds, Wed, Feb 16, 2011 05:16:01 +0100: > >> Most of the changes are pretty spread out and small, with drivers/gpu > >> (radeon and i915) somewhat standing out from the pack.