Re: [PATCH] gpu: drm: tegra: Adding new typedef vm_fault_t

2018-05-14 Thread Thierry Reding
On Tue, Apr 17, 2018 at 07:17:55PM +0530, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a distinct type. >

Re: [PATCH] gpu: drm: tegra: Adding new typedef vm_fault_t

2018-05-12 Thread Souptick Joarder
On Mon, Apr 23, 2018 at 4:24 PM, Matthew Wilcox wrote: > On Wed, Apr 18, 2018 at 10:24:39AM +0200, Thierry Reding wrote: >> > @@ -437,20 +436,7 @@ static int tegra_bo_fault(struct vm_fault *vmf) >> > offset = (vmf->address - vma->vm_start) >> PAGE_SHIFT; >> > page =

Re: [PATCH] gpu: drm: tegra: Adding new typedef vm_fault_t

2018-04-24 Thread Matthew Wilcox
On Wed, Apr 18, 2018 at 10:24:39AM +0200, Thierry Reding wrote: > > @@ -437,20 +436,7 @@ static int tegra_bo_fault(struct vm_fault *vmf) > > offset = (vmf->address - vma->vm_start) >> PAGE_SHIFT; > > page = bo->pages[offset]; > > > > - err = vm_insert_page(vma, vmf->address, page); > >

Re: [PATCH] gpu: drm: tegra: Adding new typedef vm_fault_t

2018-04-19 Thread Souptick Joarder
> This new function returns VM_FAULT_NOPAGE only for 0 and -EBUSY, whereas > we used to return VM_FAULT_NOPAGE for -EAGAIN, -ERESTARTSYS and -EINTR > as well. Previously vm_insert_page unable to return VM_FAULT_ type due to which different drivers have their own mapping from err to VM_FAULT_

Re: [PATCH] gpu: drm: tegra: Adding new typedef vm_fault_t

2018-04-18 Thread Thierry Reding
On Tue, Apr 17, 2018 at 07:17:55PM +0530, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a distinct type. >

[PATCH] gpu: drm: tegra: Adding new typedef vm_fault_t

2018-04-18 Thread Souptick Joarder
Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. Reference id -> 1c8f422059ae ("mm: change return type to vm_fault_t")

[PATCH] gpu: drm: tegra: Adding new typedef vm_fault_t

2018-04-17 Thread Souptick Joarder
Use new return type vm_fault_t for fault handler in vm_operations_struct. Signed-off-by: Souptick Joarder --- drivers/gpu/drm/tegra/gem.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/tegra/gem.c