Re: [PATCH] radeon: fix pitch alignment for non-power-of-two mipmaps on SI

2013-09-20 Thread Michel Dänzer
On Don, 2013-09-19 at 18:37 +0200, Marek Olšák wrote: On Thu, Sep 19, 2013 at 4:41 PM, Michel Dänzer mic...@daenzer.net wrote: On Don, 2013-09-19 at 14:33 +0200, Marek Olšák wrote: This fixes VM protection faults. I have a new piglit test which can iterate over all possible widths,

Re: [PATCH] radeon: fix pitch alignment for non-power-of-two mipmaps on SI

2013-09-20 Thread Marek Olšák
I agree we should make npix_x/y/z more useful, but at the same time it's a public interface and current and old Mesa depends on the seemingly incorrect values we set there. This wouldn't be an issue if we merged the allocator to Mesa, along with xf86-video-ati. Who's with me? :) In particular, I

[PATCH] radeon: fix pitch alignment for non-power-of-two mipmaps on SI

2013-09-19 Thread Marek Olšák
This fixes VM protection faults. I have a new piglit test which can iterate over all possible widths, heights, and depths (including NPOT) and tests mipmapping with various texture targets. After this is committed, I'll make a new release of libdrm and bump the libdrm version requirement in

Re: [PATCH] radeon: fix pitch alignment for non-power-of-two mipmaps on SI

2013-09-19 Thread Marek Olšák
On Thu, Sep 19, 2013 at 4:41 PM, Michel Dänzer mic...@daenzer.net wrote: On Don, 2013-09-19 at 14:33 +0200, Marek Olšák wrote: This fixes VM protection faults. I have a new piglit test which can iterate over all possible widths, heights, and depths (including NPOT) and tests mipmapping with

Re: [PATCH] radeon: fix pitch alignment for non-power-of-two mipmaps on SI

2013-09-19 Thread Marek Olšák
BTW, the intuitive explanation of the fix is that we have to minify the pitch (or POT width) instead of the NPOT width. Marek On Thu, Sep 19, 2013 at 6:37 PM, Marek Olšák mar...@gmail.com wrote: On Thu, Sep 19, 2013 at 4:41 PM, Michel Dänzer mic...@daenzer.net wrote: On Don, 2013-09-19 at