Re: [PATCH] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-13 Thread Greg KH
On Tue, Dec 13, 2022 at 08:15:20PM +0800, Jiasheng Jiang wrote: > Thanks, I found my mistake and I will submit a v2. > > > And how did you find this potential problem? What tool did you use and > > why did you not follow the documentation for properly describing the > > tool? > > I used a tool I

Re: [PATCH] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-13 Thread Jiasheng Jiang
Thanks, I found my mistake and I will submit a v2. > And how did you find this potential problem? What tool did you use and > why did you not follow the documentation for properly describing the > tool? I used a tool I wrote myself to find it, which is unpublished. Therefore, I think it is okay

Re: [PATCH] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-12 Thread Greg KH
On Tue, Dec 13, 2022 at 10:51:19AM +0800, Jiasheng Jiang wrote: > Add the check for the return value of dma_alloc_coherent > in order to avoid NULL pointer dereference. > > Fixes: 055276c13205 ("usb: gadget: add Aspeed ast2600 udc driver") > Signed-off-by: Jiasheng Jiang > --- > drivers/usb/gadg

[PATCH] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-12 Thread Jiasheng Jiang
Add the check for the return value of dma_alloc_coherent in order to avoid NULL pointer dereference. Fixes: 055276c13205 ("usb: gadget: add Aspeed ast2600 udc driver") Signed-off-by: Jiasheng Jiang --- drivers/usb/gadget/udc/aspeed_udc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/driv