Re: [PATCH] video/fbdev/matroxfb: Remove dead code

2020-05-04 Thread Souptick Joarder
On Sun, May 3, 2020 at 11:10 PM Sam Ravnborg wrote: > > Hi Souptick > > On Sat, May 02, 2020 at 03:28:11AM +0530, Souptick Joarder wrote: > > These are dead code since 3.15. If there is no plan to use it further > > it can be removed forever. > Could you explain why you conclude this is dead code

Re: [PATCH] video/fbdev/matroxfb: Remove dead code

2020-05-03 Thread Sam Ravnborg
Hi Souptick On Sat, May 02, 2020 at 03:28:11AM +0530, Souptick Joarder wrote: > These are dead code since 3.15. If there is no plan to use it further > it can be removed forever. Could you explain why you conclude this is dead code sine 3.15 - and maybe point to the commit that made it dead. I

[PATCH] video/fbdev/matroxfb: Remove dead code

2020-05-02 Thread Souptick Joarder
These are dead code since 3.15. If there is no plan to use it further it can be removed forever. Signed-off-by: Souptick Joarder --- drivers/video/fbdev/matrox/matroxfb_DAC1064.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/video/fbdev/matrox/matroxfb_DAC1064.c

Re: [PATCH] video: fbdev: matroxfb: remove dead code and set but not used variable

2020-04-08 Thread Sam Ravnborg
Hi Jason. On Fri, Apr 03, 2020 at 10:16:09AM +0800, Jason Yan wrote: > Fix the following gcc warning: > > drivers/video/fbdev/matrox/g450_pll.c:336:15: warning: variable > ‘pixel_vco’ set but not used [-Wunused-but-set-variable] > unsigned int pixel_vco; >^ > >

[PATCH] video: fbdev: matroxfb: remove dead code and set but not used variable

2020-04-03 Thread Jason Yan
Fix the following gcc warning: drivers/video/fbdev/matrox/g450_pll.c:336:15: warning: variable ‘pixel_vco’ set but not used [-Wunused-but-set-variable] unsigned int pixel_vco; ^ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/video/fbdev/matrox/g450_pll.c