Re: [PATCH] video/macfb: Remove redundant code

2019-04-01 Thread Bartlomiej Zolnierkiewicz
On 02/15/2019 09:25 AM, Geert Uytterhoeven wrote: > On Fri, Feb 15, 2019 at 3:19 AM Finn Thain wrote: >> The value of info->var.bits_per_pixel get checked in macfb_setcolreg(). >> Remove additional checks as they are redundant. >> >> macfb_defined.activate gets initialized to FB_ACTIVATE_NOW by

[PATCH] video/macfb: Remove redundant code

2019-02-18 Thread Finn Thain
The value of info->var.bits_per_pixel get checked in macfb_setcolreg(). Remove additional checks as they are redundant. macfb_defined.activate gets initialized to FB_ACTIVATE_NOW by the struct initializer. Remove redundant assignments. macfb_defined.bits_per_pixel, .width and .height all get

Re: [PATCH] video/macfb: Remove redundant code

2019-02-16 Thread Geert Uytterhoeven
On Fri, Feb 15, 2019 at 3:19 AM Finn Thain wrote: > The value of info->var.bits_per_pixel get checked in macfb_setcolreg(). > Remove additional checks as they are redundant. > > macfb_defined.activate gets initialized to FB_ACTIVATE_NOW by the struct > initializer. Remove redundant assignments. >