Re: [PATCH] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2019-11-14 Thread Andy Shevchenko
On Wed, Nov 13, 2019 at 08:38:15AM +0100, Arnd Bergmann wrote: > On Wed, Nov 13, 2019 at 8:27 AM Christoph Hellwig wrote: > > > > On Tue, Nov 12, 2019 at 10:24:23PM +, Luis Chamberlain wrote: > > > I think this would be possible if we could flop ioremap_nocache() to UC > > > instead of UC- on

Re: [PATCH] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2019-11-13 Thread Luis Chamberlain
On Wed, Nov 13, 2019 at 11:31:54AM +0200, Andy Shevchenko wrote: > On Wed, Nov 13, 2019 at 08:38:15AM +0100, Arnd Bergmann wrote: > > On Wed, Nov 13, 2019 at 8:27 AM Christoph Hellwig wrote: > > > > > > On Tue, Nov 12, 2019 at 10:24:23PM +, Luis Chamberlain wrote: > > > > I think this would be

Re: [PATCH] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2019-11-12 Thread Arnd Bergmann
On Wed, Nov 13, 2019 at 8:27 AM Christoph Hellwig wrote: > > On Tue, Nov 12, 2019 at 10:24:23PM +, Luis Chamberlain wrote: > > I think this would be possible if we could flop ioremap_nocache() to UC > > instead of UC- on x86. Otherwise, I can't see how we can remove this by > > still not allow

Re: [PATCH] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2019-11-12 Thread Luis Chamberlain
On Tue, Nov 12, 2019 at 03:26:35PM +0100, Daniel Vetter wrote: > On Tue, Nov 12, 2019 at 3:06 PM Christoph Hellwig wrote: > > On Tue, Nov 12, 2019 at 02:04:16PM +0100, Daniel Vetter wrote: > > > Wut ... Maybe I'm missing something, but from how we use mtrr in other > > > gpu drivers it's a) either

Re: [PATCH] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2019-11-12 Thread Luis Chamberlain
On Tue, Nov 12, 2019 at 03:06:31PM +0100, Christoph Hellwig wrote: > On Tue, Nov 12, 2019 at 02:04:16PM +0100, Daniel Vetter wrote: > > Wut ... Maybe I'm missing something, but from how we use mtrr in other > > gpu drivers it's a) either you use MTRR because that's all you got or > > b) you use pat

Re: [PATCH] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2019-11-12 Thread Daniel Vetter
On Tue, Nov 12, 2019 at 3:06 PM Christoph Hellwig wrote: > On Tue, Nov 12, 2019 at 02:04:16PM +0100, Daniel Vetter wrote: > > Wut ... Maybe I'm missing something, but from how we use mtrr in other > > gpu drivers it's a) either you use MTRR because that's all you got or > > b) you use pat. Mixing

Re: [PATCH] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2019-11-12 Thread Daniel Vetter
On Tue, Nov 12, 2019 at 11:55 AM Christoph Hellwig wrote: > > On Mon, Nov 11, 2019 at 08:22:50PM +0100, Arnd Bergmann wrote: > > ioremap_uc() is only meaningful on old x86-32 systems with the PAT > > extension, and on ia64 with its slightly unconventional ioremap() > > behavior, everywhere else th

[PATCH] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64

2019-11-11 Thread Arnd Bergmann
ioremap_uc() is only meaningful on old x86-32 systems with the PAT extension, and on ia64 with its slightly unconventional ioremap() behavior, everywhere else this is the same as ioremap() anyway. Change the only driver that still references ioremap_uc() to only do so on x86-32/ia64 in order to al