Re: [PATCH] video: fbdev: fix setting of pixclock because a pass-by-value error

2020-09-08 Thread Bartlomiej Zolnierkiewicz
On 7/23/20 7:02 PM, Colin King wrote: > From: Colin Ian King > > The pixclock is being set locally because it is being passed as a > pass-by-value argument rather than pass-by-reference, so the computed > pixclock is never being set in var->pixclock. Fix this by passing > by reference. > > [Th

[PATCH] video: fbdev: fix setting of pixclock because a pass-by-value error

2020-07-23 Thread Colin King
From: Colin Ian King The pixclock is being set locally because it is being passed as a pass-by-value argument rather than pass-by-reference, so the computed pixclock is never being set in var->pixclock. Fix this by passing by reference. [This dates back to 2002, I found the offending commit from