[PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-24 Thread Pavel Machek
On Thu 2015-01-29 14:11:25, Dave Airlie wrote: > These two copy to/from VGA memory, however on the Silicon > Motion SMI750 VGA card on a 64-bit system cause console corruption. > > This is due to the hw being buggy and not handling a 64-bit transaction > correctly. > > We could try and create a 3

[PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-09 Thread One Thousand Gnomes
On Mon, 9 Feb 2015 11:00:55 + Daniel Stone wrote: > On 9 February 2015 at 10:49, Geert Uytterhoeven > wrote: > > On Mon, Feb 9, 2015 at 11:35 AM, Daniel Stone > > wrote: > >> On 5 February 2015 at 11:35, One Thousand Gnomes > >> wrote: > >>> #if defined (CONFIG_SUPPORT_SHITE_VGA_ADAPTERS

[PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-09 Thread Geert Uytterhoeven
On Mon, Feb 9, 2015 at 11:35 AM, Daniel Stone wrote: > On 5 February 2015 at 11:35, One Thousand Gnomes > wrote: >>> If I'm not mistaken, that would be as simple as adding >>> >>> #define VT_BUF_HAVE_RW. >>> #define scr_writew(val, addr) (*(addr) = (val)) >>> #define scr_readw(addr) (

[PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-09 Thread Daniel Stone
On 9 February 2015 at 10:49, Geert Uytterhoeven wrote: > On Mon, Feb 9, 2015 at 11:35 AM, Daniel Stone wrote: >> On 5 February 2015 at 11:35, One Thousand Gnomes >> wrote: >>> #if defined (CONFIG_SUPPORT_SHITE_VGA_ADAPTERS) >>> >>> #endif >>> >>> around that and its sorted as an option everyone

[PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-09 Thread Daniel Stone
On 5 February 2015 at 11:35, One Thousand Gnomes wrote: >> If I'm not mistaken, that would be as simple as adding >> >> #define VT_BUF_HAVE_RW. >> #define scr_writew(val, addr) (*(addr) = (val)) >> #define scr_readw(addr) (*(addr)) >> >> to arch/x86/include/asm/vga.h. > > and stick an

[PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-05 Thread One Thousand Gnomes
> If I'm not mistaken, that would be as simple as adding > > #define VT_BUF_HAVE_RW. > #define scr_writew(val, addr) (*(addr) = (val)) > #define scr_readw(addr) (*(addr)) > > to arch/x86/include/asm/vga.h. and stick an #if defined (CONFIG_SUPPORT_SHITE_VGA_ADAPTERS) #endif around

[PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-05 Thread Geert Uytterhoeven
On Tue, Feb 3, 2015 at 4:54 PM, One Thousand Gnomes wrote: > On Thu, 29 Jan 2015 15:40:33 -0800 > Linus Torvalds wrote: > >> On Wed, Jan 28, 2015 at 8:11 PM, Dave Airlie wrote: >> > >> > Linus, this came up a while back I finally got some confirmation >> > that it fixes those servers. >> >> I'm

[PATCH] vt_buffer: drop console buffer copying optimisations

2015-02-03 Thread One Thousand Gnomes
On Thu, 29 Jan 2015 15:40:33 -0800 Linus Torvalds wrote: > On Wed, Jan 28, 2015 at 8:11 PM, Dave Airlie wrote: > > > > Linus, this came up a while back I finally got some confirmation > > that it fixes those servers. > > I'm certainly ok with this. which way should it go in? The users are: > >

[PATCH] vt_buffer: drop console buffer copying optimisations

2015-01-30 Thread Dave Airlie
On 30 January 2015 at 10:03, Linus Torvalds wrote: > On Thu, Jan 29, 2015 at 3:57 PM, Greg Kroah-Hartman > wrote: >> >> I can take this through the tty tree, but can I put it in linux-next and >> wait for the 3.20 merge window to give people who might notice a >> slow-down a chance to object? > >

[PATCH] vt_buffer: drop console buffer copying optimisations

2015-01-29 Thread Linus Torvalds
On Thu, Jan 29, 2015 at 3:57 PM, Greg Kroah-Hartman wrote: > > I can take this through the tty tree, but can I put it in linux-next and > wait for the 3.20 merge window to give people who might notice a > slow-down a chance to object? Yes. The problem only affects one (or a couple of) truly outra

[PATCH] vt_buffer: drop console buffer copying optimisations

2015-01-29 Thread Greg Kroah-Hartman
On Thu, Jan 29, 2015 at 03:40:33PM -0800, Linus Torvalds wrote: > On Wed, Jan 28, 2015 at 8:11 PM, Dave Airlie wrote: > > > > Linus, this came up a while back I finally got some confirmation > > that it fixes those servers. > > I'm certainly ok with this. which way should it go in? The users are:

[PATCH] vt_buffer: drop console buffer copying optimisations

2015-01-29 Thread Linus Torvalds
On Wed, Jan 28, 2015 at 8:11 PM, Dave Airlie wrote: > > Linus, this came up a while back I finally got some confirmation > that it fixes those servers. I'm certainly ok with this. which way should it go in? The users are: - drivers/tty/vt/vt.c (Greg KH, "tty layer") - drivers/video/console/*

[PATCH] vt_buffer: drop console buffer copying optimisations

2015-01-29 Thread Dave Airlie
These two copy to/from VGA memory, however on the Silicon Motion SMI750 VGA card on a 64-bit system cause console corruption. This is due to the hw being buggy and not handling a 64-bit transaction correctly. We could try and create a 32-bit version of these routines, but I'm not sure the optimis

[PATCH] vt_buffer: drop console buffer copying optimisations

2015-01-29 Thread Peter Hurley
On 01/28/2015 11:11 PM, Dave Airlie wrote: > These two copy to/from VGA memory, however on the Silicon > Motion SMI750 VGA card on a 64-bit system cause console corruption. > > This is due to the hw being buggy and not handling a 64-bit transaction > correctly. > > We could try and create a 32-bi